netdev - Re: [PATCH v2 1/3] nfs/blocklayout: Fix compilation error (`make W=1`) in bl_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5bdb5b9d-30eb-4511-b839-21b073a6ce43@app.fastmail.com>
Date: Wed, 04 Feb 2026 10:53:26 -0500
From: "Anna Schumaker" <anna@...nel.org>
To: "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
 "Chuck Lever" <chuck.lever@...cle.com>, NeilBrown <neil@...wn.name>,
 "Jeff Layton" <jlayton@...nel.org>, linux-nfs@...r.kernel.org,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org, llvm@...ts.linux.dev
Cc: "Trond Myklebust" <trondmy@...nel.org>,
 "Olga Kornievskaia" <okorniev@...hat.com>, "Dai Ngo" <Dai.Ngo@...cle.com>,
 "Tom Talpey" <tom@...pey.com>, "David S. Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>,
 "Paolo Abeni" <pabeni@...hat.com>, "Simon Horman" <horms@...nel.org>,
 "Nathan Chancellor" <nathan@...nel.org>,
 "Nick Desaulniers" <nick.desaulniers+lkml@...il.com>,
 "Bill Wendling" <morbo@...gle.com>, "Justin Stitt" <justinstitt@...gle.com>
Subject: Re: [PATCH v2 1/3] nfs/blocklayout: Fix compilation error (`make W=1`) in
 bl_write_pagelist()

On Wed, Feb 4, 2026, at 4:41 AM, Andy Shevchenko wrote:
> Clang compiler is not happy about set but unused variable
> (when dprintk() is no-op):
>
> .../blocklayout/blocklayout.c:384:9: error: variable 'count' set but 
> not used [-Werror,-Wunused-but-set-variable]
>
> Remove a leftover from the previous cleanup.
>
> Fixes: 3a6fd1f004fc ("pnfs/blocklayout: remove read-modify-write 
> handling in bl_write_pagelist")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Acked-by: Anna Schumaker <anna.schumkaer@...cle.com>

> ---
>  fs/nfs/blocklayout/blocklayout.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/nfs/blocklayout/blocklayout.c 
> b/fs/nfs/blocklayout/blocklayout.c
> index 0e4c67373e4f..83e4a32b3018 100644
> --- a/fs/nfs/blocklayout/blocklayout.c
> +++ b/fs/nfs/blocklayout/blocklayout.c
> @@ -381,14 +381,13 @@ bl_write_pagelist(struct nfs_pgio_header *header, 
> int sync)
>  	sector_t isect, extent_length = 0;
>  	struct parallel_io *par = NULL;
>  	loff_t offset = header->args.offset;
> -	size_t count = header->args.count;
>  	struct page **pages = header->args.pages;
>  	int pg_index = header->args.pgbase >> PAGE_SHIFT;
>  	unsigned int pg_len;
>  	struct blk_plug plug;
>  	int i;
> 
> -	dprintk("%s enter, %zu@...d\n", __func__, count, offset);
> +	dprintk("%s enter, %u@...d\n", __func__, header->args.count, offset);
> 
>  	/* At this point, header->page_aray is a (sequential) list of nfs_pages.
>  	 * We want to write each, and if there is an error set pnfs_error
> @@ -429,7 +428,6 @@ bl_write_pagelist(struct nfs_pgio_header *header, int sync)
>  		}
> 
>  		offset += pg_len;
> -		count -= pg_len;
>  		isect += (pg_len >> SECTOR_SHIFT);
>  		extent_length -= (pg_len >> SECTOR_SHIFT);
>  	}
> -- 
> 2.50.1