netdev - Re: [PATCH net-next v4 12/13] netlink: specs: Add ethernet port listing with ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e355184-1593-4bac-bc57-40258cd56c78@bootlin.com>
Date: Wed, 4 Feb 2026 17:53:01 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, Andrew Lunn <andrew@...n.ch>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Russell King <linux@...linux.org.uk>, Heiner Kallweit
 <hkallweit1@...il.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com,
 Christophe Leroy <christophe.leroy@...roup.eu>,
 Herve Codina <herve.codina@...tlin.com>,
 Florian Fainelli <f.fainelli@...il.com>,
 Vladimir Oltean <vladimir.oltean@....com>,
 Köry Maincent <kory.maincent@...tlin.com>,
 Marek Behún <kabel@...nel.org>,
 Oleksij Rempel <o.rempel@...gutronix.de>,
 Nicolò Veronese <nicveronese@...il.com>,
 Simon Horman <horms@...nel.org>, mwojtas@...omium.org,
 Romain Gantois <romain.gantois@...tlin.com>,
 Daniel Golle <daniel@...rotopia.org>,
 Dimitri Fedrau <dimitri.fedrau@...bherr.com>
Subject: Re: [PATCH net-next v4 12/13] netlink: specs: Add ethernet port
 listing with ethtool

Hi Jakub

On 04/02/2026 17:14, Jakub Kicinski wrote:
> On Tue,  3 Feb 2026 18:28:36 +0100 Maxime Chevallier wrote:
>> +Request contents:
>> +
>> +====================================  ======  =================================
>> +  ``ETHTOOL_A_PORT_HEADER``             nested  request header
>> +  ``ETHTOOL_A_PORT_ID``                 u32     port id
>> +  ====================================  ======  ===============================
> 
> No idea what happened but suddenly last doc build run started noticing
> that this table is malformed. Even tho the patches have been present in
> previous builds already and there was no error. Very odd. But the table
> does look wonky..
> 
> Documentation/networking/ethtool-netlink.rst:2538: ERROR: Malformed table.
> Bottom/header table border does not match top border.
> 
> ====================================  ======  =================================
>   ``ETHTOOL_A_PORT_HEADER``             nested  request header
>   ``ETHTOOL_A_PORT_ID``                 u32     port id
>   ====================================  ======  ===============================

Yeah I noticed too late... Simon made the same comment on V3, but his
review and my V4 crossed and the issue is still there, as are a few
other ones like the smatch problem :(

I'll slow down my horses a bit :)

Thanks,

Maxime