netdev - Re: [PATCH net] net: hns3: fix double free issue for tx spare buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ce0492b-d17f-458a-a4df-5849ade047a0@intel.com>
Date: Wed, 4 Feb 2026 13:20:52 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jijie Shao <shaojijie@...wei.com>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<andrew+netdev@...n.ch>, <horms@...nel.org>
CC: <shenjian15@...wei.com>, <liuyonglong@...wei.com>,
	<chenhao418@...wei.com>, <lantao5@...wei.com>,
	<huangdonghua3@...artners.com>, <yangshuaisong@...artners.com>,
	<jonathan.cameron@...wei.com>, <salil.mehta@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: hns3: fix double free issue for tx spare buffer



On 2/4/2026 6:25 AM, Jijie Shao wrote:
>> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> 
> Thank you for your careful review, I apologize for the trouble this 
> patch has caused you.
> 
> We considered the logic to be quite complex, so we added comments in the 
> code to explain it.
> However, for reviewers who are not familiar with our driver, these 
> comments might be a bit unclear.
> I will add more detailed explanations in the commit message for v2.
> 
> Thanks,
> Jijie Shao

Appreciate it, thanks! Please feel free to add my Reviewed-by to v2 if 
the code remains unchanged.

Regards,
Jake