netdev - Re: [PATCH net-next v4] net: usb: introduce usbnet_mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADkSEUjackVDC4+rti_V4XxjZ18YkD_6jdx7vKKkjRErExG0kQ@mail.gmail.com>
Date: Tue, 3 Feb 2026 19:48:41 -0800
From: Ethan Nelson-Moore <enelsonmoore@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-usb@...r.kernel.org, netdev@...r.kernel.org, 
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Andrew Lunn <andrew@...n.ch>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Peter Korsgaard <peter@...sgaard.com>, Steve Glendinning <steve.glendinning@...well.net>, 
	Oliver Neukum <oneukum@...e.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Oleksij Rempel <o.rempel@...gutronix.de>, Max Schulze <max.schulze@...ine.de>, 
	Krzysztof Hałasa <khalasa@...p.pl>
Subject: Re: [PATCH net-next v4] net: usb: introduce usbnet_mii_ioctl helper function

On Tue, Feb 3, 2026 at 1:49 AM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> I'm not sure. This makes it harder to read for no benefit. All non-static
> functions are part of the API.
While I can't fault your reasoning, respectfully, I think that
removing "extern" would just be pointless code churn.

Ethan