netdev - Re: [PATCH v2 net-next 4/4] tcp: move __reqsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iK8_f5siuNOrDMLNL2ctSN_rYyuDFRh0iWbpAnUuvkBug@mail.gmail.com>
Date: Wed, 4 Feb 2026 06:43:07 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Neal Cardwell <ncardwell@...gle.com>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH v2 net-next 4/4] tcp: move __reqsk_free() out of line

On Wed, Feb 4, 2026 at 1:38 AM Kuniyuki Iwashima <kuniyu@...gle.com> wrote:
>
> On Mon, Feb 2, 2026 at 9:22 PM Eric Dumazet <edumazet@...gle.com> wrote:
> >
> > Inlining __reqsk_free() is overkill, let's reclaim 2 Kbytes of text.
> >

> > +void __reqsk_free(struct request_sock *req)
> > +{
> > +       req->rsk_ops->destructor(req);
> > +       if (req->rsk_listener)
> > +               sock_put(req->rsk_listener);
> > +       kfree(req->saved_syn);
> > +       kmem_cache_free(req->rsk_ops->slab, req);
> > +}
> > +EXPORT_IPV6_MOD_GPL(__reqsk_free);
>
> Probably this needs to be EXPORT_SYMBOL_GPL() due to
> drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c ?
>

Good catch indeed :/

What an abomination this copy/paste of TCP stack.

Will send this change in V2, thanks.