netdev - Re: [PATCH net-next 07/15] mptcp: allow overridden write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d9a4ad0-7e96-4927-aec7-0992613d1282@kernel.org>
Date: Thu, 5 Feb 2026 09:23:11 +0100
From: Matthieu Baerts <matttbe@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Mat Martineau <martineau@...nel.org>, Geliang Tang <geliang@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Shuah Khan <shuah@...nel.org>, netdev@...r.kernel.org,
 mptcp@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Gang Yan <yangang@...inos.cn>
Subject: Re: [PATCH net-next 07/15] mptcp: allow overridden write_space to be
 invoked

Hi Jakub,

On 05/02/2026 03:44, Jakub Kicinski wrote:
> On Wed, 4 Feb 2026 11:47:13 +0100 Matthieu Baerts wrote:
>>> diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
>>> index f4bfe91ca7f9..0bd1ee860316 100644
>>> --- a/net/mptcp/protocol.h
>>> +++ b/net/mptcp/protocol.h
>>> @@ -975,7 +975,7 @@ static inline void mptcp_write_space(struct sock *sk)
>>>  	/* pairs with memory barrier in mptcp_poll */
>>>  	smp_mb();
>>>  	if (mptcp_stream_memory_free(sk, 1))
>>> -		sk_stream_write_space(sk);
>>> +		INDIRECT_CALL_1(sk->sk_write_space, sk_stream_write_space, sk);  
>>
>> Is it possible to drop only this patch from this series? It is
>> independent of the rest, and the AI review tool spotted that
>> sk->sk_write_space is not sk_stream_write_space by default.
>>
>> I can send a v2 without this patch if preferred.
> 
> Ack, looks like this is the last patch in terms of real code
> so can do.

Thank you for having applied this series without this patch!

> BTW I've been offering other sub-maintainers to
> run the AI stuff on their patchwork instances. Looks like
> there's a mptcp instance in k.org patchwork. 
> 
> LMK if you want me to hook it up (..when time allows).

That would be great to catch issues early, and avoid multiple versions.
So, yes please, but take your time, that's not urgent. Thank you!

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.