netdev - Re: [PATCH net-next v2] net: ti: icssg: Remove dedicated workqueue for ndo_set_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc5ac28e-d830-402f-b5a2-741c20263aa3@ti.com>
Date: Thu, 5 Feb 2026 14:04:16 +0530
From: MD Danish Anwar <danishanwar@...com>
To: Kevin Hao <haokexin@...il.com>, <netdev@...r.kernel.org>
CC: Roger Quadros <rogerq@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Meghana
 Malladi" <m-malladi@...com>, Jacob Keller <jacob.e.keller@...el.com>, "Vadim
 Fedorenko" <vadim.fedorenko@...ux.dev>, Himanshu Mittal <h-mittal1@...com>,
	Simon Horman <horms@...nel.org>, Byungchul Park <byungchul@...com>, "Markus
 Elfring" <elfring@...rs.sourceforge.net>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH net-next v2] net: ti: icssg: Remove dedicated workqueue
 for ndo_set_rx_mode callback



On 05/02/26 11:55 am, Kevin Hao wrote:
> Currently, both the icssg-prueth and icssg-prueth-sr1 drivers create
> a dedicated 'emac->cmd_wq' workqueue.
> 
> In the icssg-prueth-sr1 driver, this workqueue is not utilized at all.
> 
> In the icssg-prueth driver, the workqueue is only used to execute the
> actual processing of ndo_set_rx_mode. However, creating a dedicated
> workqueue for such a simple use case is unnecessary. To simplify the
> code, switch to using the system default workqueue instead.
> 
> Signed-off-by: Kevin Hao <haokexin@...il.com>
> ---
> While addressing an issue in the cpsw driver, I based my fix [1] on the
> implementation of the emac_ndo_set_rx_mode() function in icssg. During review,
> Jakub pointed out that the dedicated workqueue for the ndo_set_rx_mode
> callback might be unnecessary [2]. I subsequently used the system workqueue for
> this purpose in the cpsw driver, and it performed as expected. Therefore,
> I believe the same approach can be applied to the icssg driver. This
> patch aim to remove this dedicated workqueue for icssg drivers.
> 
> Please note: I do not have access to a board that supports the CSSG PRU
> Ethernet controller, so this change has only been build-tested.
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=c0b5dc73a38f954e780f93a549b8fe225235c07a
> [2] https://lore.kernel.org/all/20260127190836.6a420768@kernel.org/
> ---
> Cc: MD Danish Anwar <danishanwar@...com>
> Cc: Roger Quadros <rogerq@...nel.org>
> Cc: Andrew Lunn <andrew+netdev@...n.ch>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: Meghana Malladi <m-malladi@...com>
> Cc: Jacob Keller <jacob.e.keller@...el.com>
> Cc: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> Cc: Himanshu Mittal <h-mittal1@...com>
> Cc: Simon Horman <horms@...nel.org>
> Cc: Byungchul Park <byungchul@...com>
> Cc: Markus Elfring <elfring@...rs.sourceforge.net>
> Cc: linux-arm-kernel@...ts.infradead.org
> ---

Meghana, Can you please test this patch on AM64x and verify icssg_prueth
driver functionalities.

-- 
Thanks and Regards,
Danish