netdev - RE: [Intel-wired-lan] [PATCH iwl-net v2] ixgbevf: fix link setup issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8985CFA7F1485BA2BBF190D18F99A@IA3PR11MB8985.namprd11.prod.outlook.com>
Date: Thu, 5 Feb 2026 11:38:59 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "stable@...r.kernel.org" <stable@...r.kernel.org>,
	"Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>, "Loktionov, Aleksandr"
	<aleksandr.loktionov@...el.com>, "Kwapulinski, Piotr"
	<piotr.kwapulinski@...el.com>, Paul Menzel <pmenzel@...gen.mpg.de>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v2] ixgbevf: fix link setup
 issue

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Jedrzej
> Jagielski
> Sent: Wednesday, December 10, 2025 12:27
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; netdev@...r.kernel.org;
> stable@...r.kernel.org; Jagielski, Jedrzej <jedrzej.jagielski@...el.com>;
> Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Kwapulinski, Piotr
> <piotr.kwapulinski@...el.com>; Paul Menzel <pmenzel@...gen.mpg.de>
> Subject: [Intel-wired-lan] [PATCH iwl-net v2] ixgbevf: fix link setup issue
> 
> It may happen that VF spawned for E610 adapter has problem with setting link up.
> This happens when ixgbevf supporting mailbox API 1.6 cooperates with PF driver
> which doesn't support this version of API, and hence doesn't support new
> approach for getting PF link data.
> 
> In that case VF asks PF to provide link data but as PF doesn't support it, returns -
> EOPNOTSUPP what leads to early bail from link configuration sequence.
> 
> Avoid such situation by using legacy VFLINKS approach whenever negotiated API
> version is less than 1.6.
> 
> To reproduce the issue just create VF and set its link up - adapter must be any
> from the E610 family, ixgbevf must support API 1.6 or higher while ixgbevf must
> not.
> 
> Fixes: 53f0eb62b4d2 ("ixgbevf: fix getting link speed data for E610 devices")
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Reviewed-by: Piotr Kwapulinski <piotr.kwapulinski@...el.com>
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
> Cc: stable@...r.kernel.org
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
> ---
> v2: extend the commit msg (Paul)
> ---
>  drivers/net/ethernet/intel/ixgbevf/vf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c
> b/drivers/net/ethernet/intel/ixgbevf/vf.c
> index 29c5ce967938..8af88f615776 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/vf.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/vf.c
> @@ -846,7 +846,8 @@ static s32 ixgbevf_check_mac_link_vf(struct ixgbe_hw
> *hw,
>  	if (!mac->get_link_status)
>  		goto out;
> 
> -	if (hw->mac.type == ixgbe_mac_e610_vf) {
> +	if (hw->mac.type == ixgbe_mac_e610_vf &&
> +	    hw->api_version >= ixgbe_mbox_api_16) {
>  		ret_val = ixgbevf_get_pf_link_state(hw, speed, link_up);
>  		if (ret_val)
>  			goto out;
> --
> 2.31.1

Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>