netdev - Re: [PATCH bpf-next v6 09/17] bpf: Prepare for bpf_selem_unlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202602052147.PjiFTJlT-lkp@intel.com>
Date: Thu, 5 Feb 2026 21:48:03 +0800
From: kernel test robot <lkp@...el.com>
To: Amery Hung <ameryhung@...il.com>, bpf@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	netdev@...r.kernel.org, alexei.starovoitov@...il.com,
	andrii@...nel.org, daniel@...earbox.net, memxor@...il.com,
	martin.lau@...nel.org, kpsingh@...nel.org, yonghong.song@...ux.dev,
	song@...nel.org, haoluo@...gle.com, ameryhung@...il.com,
	kernel-team@...a.com
Subject: Re: [PATCH bpf-next v6 09/17] bpf: Prepare for
 bpf_selem_unlink_nofail()

Hi Amery,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Amery-Hung/bpf-Select-bpf_local_storage_map_bucket-based-on-bpf_local_storage/20260205-150959
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20260205070208.186382-10-ameryhung%40gmail.com
patch subject: [PATCH bpf-next v6 09/17] bpf: Prepare for bpf_selem_unlink_nofail()
config: x86_64-buildonly-randconfig-002-20260205 (https://download.01.org/0day-ci/archive/20260205/202602052147.PjiFTJlT-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260205/202602052147.PjiFTJlT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602052147.PjiFTJlT-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/bpf/bpf_local_storage.c:289:8: warning: variable 'owner' set but not used [-Wunused-but-set-variable]
     289 |         void *owner;
         |               ^
   kernel/bpf/bpf_local_storage.c:64:13: warning: unused function 'selem_linked_to_map' [-Wunused-function]
      64 | static bool selem_linked_to_map(const struct bpf_local_storage_elem *selem)
         |             ^~~~~~~~~~~~~~~~~~~
   2 warnings generated.


vim +/owner +289 kernel/bpf/bpf_local_storage.c

588d80f1d996ea Amery Hung       2026-02-04  278  
450af8d0f6be2e KP Singh         2020-08-25  279  /* local_storage->lock must be held and selem->local_storage == local_storage.
450af8d0f6be2e KP Singh         2020-08-25  280   * The caller must ensure selem->smap is still valid to be
450af8d0f6be2e KP Singh         2020-08-25  281   * dereferenced for its smap->elem_size and smap->cache_idx.
450af8d0f6be2e KP Singh         2020-08-25  282   */
c83597fa5dc6b3 Yonghong Song    2022-10-25  283  static bool bpf_selem_unlink_storage_nolock(struct bpf_local_storage *local_storage,
450af8d0f6be2e KP Singh         2020-08-25  284  					    struct bpf_local_storage_elem *selem,
0e854e55356908 Amery Hung       2025-11-14  285  					    struct hlist_head *free_selem_list)
450af8d0f6be2e KP Singh         2020-08-25  286  {
450af8d0f6be2e KP Singh         2020-08-25  287  	struct bpf_local_storage_map *smap;
450af8d0f6be2e KP Singh         2020-08-25  288  	bool free_local_storage;
450af8d0f6be2e KP Singh         2020-08-25 @289  	void *owner;
450af8d0f6be2e KP Singh         2020-08-25  290  
0fe4b381a59ebc KP Singh         2021-12-24  291  	smap = rcu_dereference_check(SDATA(selem)->smap, bpf_rcu_lock_held());
450af8d0f6be2e KP Singh         2020-08-25  292  	owner = local_storage->owner;
450af8d0f6be2e KP Singh         2020-08-25  293  
450af8d0f6be2e KP Singh         2020-08-25  294  	free_local_storage = hlist_is_singular_node(&selem->snode,
450af8d0f6be2e KP Singh         2020-08-25  295  						    &local_storage->list);
450af8d0f6be2e KP Singh         2020-08-25  296  
588d80f1d996ea Amery Hung       2026-02-04  297  	bpf_selem_unlink_storage_nolock_misc(selem, smap, local_storage,
588d80f1d996ea Amery Hung       2026-02-04  298  					     free_local_storage);
450af8d0f6be2e KP Singh         2020-08-25  299  
450af8d0f6be2e KP Singh         2020-08-25  300  	hlist_del_init_rcu(&selem->snode);
450af8d0f6be2e KP Singh         2020-08-25  301  
5bd5bab76669b1 Martin KaFai Lau 2024-10-23  302  	hlist_add_head(&selem->free_node, free_selem_list);
dcf456c9a095a6 KP Singh         2022-04-18  303  
450af8d0f6be2e KP Singh         2020-08-25  304  	return free_local_storage;
450af8d0f6be2e KP Singh         2020-08-25  305  }
450af8d0f6be2e KP Singh         2020-08-25  306  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki