netdev - Re: [EXTERNAL] Re: [PATCH net-next] net: marvell: prestera: fix FEC error message for SFP ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260204182758.7ba3fd43@kernel.org>
Date: Wed, 4 Feb 2026 18:27:58 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Elad Nachman <enachman@...vell.com>, Alok Tiwari
 <alok.a.tiwari@...cle.com>
Cc: Jonas Gorski <jonas.gorski@...il.com>, "Taras Chornyi [C]"
 <tchornyi@...vell.com>, "Volodymyr Mytnyk [C]" <vmytnyk@...vell.com>,
 Yevhen Orlov <yevhen.orlov@...ision.eu>, "Vadym Kochan [C]"
 <vkochan@...vell.com>, Taras Chornyi <taras.chornyi@...ision.eu>,
 "pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
 <edumazet@...gle.com>, "davem@...emloft.net" <davem@...emloft.net>,
 "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "alok.a.tiwarilinux@...il.com"
 <alok.a.tiwarilinux@...il.com>
Subject: Re: [EXTERNAL] Re: [PATCH net-next] net: marvell: prestera: fix FEC
 error message for SFP ports

On Wed, 4 Feb 2026 13:13:31 +0000 Elad Nachman wrote:
> > > I'm pretty sure that the condition here is wrong, not the error message.
> > >
> > > AFAIK it doesn't make sense to configure FEC on ethernet/copper ports,
> > > but for SFP ports, it may be required depending on the transceiver or
> > > cable used, especially for fiber modules.
> > >
> > > I may be wrong though.
> > >
> > > This check was introduced with bb5dbf2cc64d ("net: marvell: prestera:
> > > add firmware v4.0 support"), but that commit does not offer any
> > > explanation for it in the commit message.  
> > 
> > Elad, could you clarify this? A bit hard to tell whether CR is included
> > in "SFP" from glancing at the code.  
> 
> Basically, the supported devices have FEC on 10G-BASE-KR and upwards
> (CR: from 40G-BASE-CR), and for USXGMII SERDES, which drives multiple
> copper PHYs.
> 
> Judging based on all of the above,
> I think it is best to remove this check (plus said error message)
> altogether and let the firmware return an error if the mode/speed/FEC
> combination is invalid.

SG, thanks for explaining

Alok, pls respin as suggested.
-- 
pw-bot: cr