netdev - Re: [PATCH net] net: ti: icssg-prueth: Add dependency on HSR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260205100315.134766d7@kernel.org>
Date: Thu, 5 Feb 2026 10:03:15 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Kevin Hao <haokexin@...il.com>
Cc: netdev@...r.kernel.org, stable@...r.kernel.org, MD Danish Anwar
 <danishanwar@...com>, Roger Quadros <rogerq@...nel.org>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net] net: ti: icssg-prueth: Add dependency on HSR

On Tue, 03 Feb 2026 20:43:08 +0800 Kevin Hao wrote:
> Commit 95540ad6747c ("net: ti: icssg-prueth: Add support for HSR frame
> forward offload") introduces support for offloading HSR frame forwarding,
> which relies on functions such as is_hsr_master() provided by the HSR
> module. Therefore, a dependency on HSR should be added for this driver.
> Otherwise, the following build failures will occur when icssg-prueth is

> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index fe5b2926d8ab060d83f5a58d91e749a45c6cea18..48aa3457fd6d7fd99147e4fb1148559d6fcba082 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -192,6 +192,7 @@ config TI_ICSSG_PRUETH
>  	depends on NET_SWITCHDEV
>  	depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER
>  	depends on PTP_1588_CLOCK_OPTIONAL
> +	depends on HSR

Looks like there are appropriate static inlines in place to handle
HSR=n in the driver the only problematic case is if HSR is m and
drivers is y, no?

	depends on HSR || HSR=n

is likely more suitable.
-- 
pw-bot: cr