netdev - Re: [PATCH net 1/2] net: cpsw_new: Fix unnecessary netdev unregistration in cpsw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7bd135730919a8a5c5d4b2ccaae945c76c7376e.camel@gmail.com>
Date: Thu, 05 Feb 2026 20:03:40 +0100
From: Alexander Sverdlin <alexander.sverdlin@...il.com>
To: Kevin Hao <haokexin@...il.com>, netdev@...r.kernel.org
Cc: Siddharth Vadapalli <s-vadapalli@...com>, Roger Quadros
 <rogerq@...nel.org>,  Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet	 <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni	 <pabeni@...hat.com>, Vladimir
 Oltean <vladimir.oltean@....com>, Saeed Mahameed	 <saeedm@...dia.com>,
 Daniel Zahka <daniel.zahka@...il.com>, Lorenzo Bianconi	
 <lorenzo@...nel.org>, Nicolas Dichtel <nicolas.dichtel@...nd.com>, Murali
 Karicheri <m-karicheri2@...com>, Ilias Apalodimas
 <ilias.apalodimas@...aro.org>, Grygorii Strashko	
 <grygorii.strashko@...com>, linux-omap@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH net 1/2] net: cpsw_new: Fix unnecessary netdev
 unregistration in cpsw_probe() error path

On Thu, 2026-02-05 at 10:47 +0800, Kevin Hao wrote:
> The current error handling in cpsw_probe() has two issues:
> - cpsw_unregister_ports() may be called before cpsw_register_ports() has
>   been executed.
> 
> - cpsw_unregister_ports() is already invoked within cpsw_register_ports()
>   in case of a register_netdev() failure, but the error path would call
>   it again.
> 
> Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")
> Signed-off-by: Kevin Hao <haokexin@...il.com>

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...il.com>

> Cc: stable@...r.kernel.org
> ---
>  drivers/net/ethernet/ti/cpsw_new.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c
> index 21af0a10626aaf0ce6ecb04837899801743f3894..b9fc31eb06134dae33427eaba06341c39eb4b41c 100644
> --- a/drivers/net/ethernet/ti/cpsw_new.c
> +++ b/drivers/net/ethernet/ti/cpsw_new.c
> @@ -2003,7 +2003,7 @@ static int cpsw_probe(struct platform_device *pdev)
>  	/* setup netdevs */
>  	ret = cpsw_create_ports(cpsw);
>  	if (ret)
> -		goto clean_unregister_netdev;
> +		goto clean_cpts;
>  
>  	/* Grab RX and TX IRQs. Note that we also have RX_THRESHOLD and
>  	 * MISC IRQs which are always kept disabled with this driver so
> @@ -2017,14 +2017,14 @@ static int cpsw_probe(struct platform_device *pdev)
>  			       0, dev_name(dev), cpsw);
>  	if (ret < 0) {
>  		dev_err(dev, "error attaching irq (%d)\n", ret);
> -		goto clean_unregister_netdev;
> +		goto clean_cpts;
>  	}
>  
>  	ret = devm_request_irq(dev, cpsw->irqs_table[1], cpsw_tx_interrupt,
>  			       0, dev_name(dev), cpsw);
>  	if (ret < 0) {
>  		dev_err(dev, "error attaching irq (%d)\n", ret);
> -		goto clean_unregister_netdev;
> +		goto clean_cpts;
>  	}
>  
>  	if (!cpsw->cpts)
> @@ -2034,7 +2034,7 @@ static int cpsw_probe(struct platform_device *pdev)
>  			       0, dev_name(&pdev->dev), cpsw);
>  	if (ret < 0) {
>  		dev_err(dev, "error attaching misc irq (%d)\n", ret);
> -		goto clean_unregister_netdev;
> +		goto clean_cpts;
>  	}
>  
>  	/* Enable misc CPTS evnt_pend IRQ */
> @@ -2043,7 +2043,7 @@ static int cpsw_probe(struct platform_device *pdev)
>  skip_cpts:
>  	ret = cpsw_register_notifiers(cpsw);
>  	if (ret)
> -		goto clean_unregister_netdev;
> +		goto clean_cpts;
>  
>  	ret = cpsw_register_devlink(cpsw);
>  	if (ret)
> @@ -2065,8 +2065,6 @@ static int cpsw_probe(struct platform_device *pdev)
>  
>  clean_unregister_notifiers:
>  	cpsw_unregister_notifiers(cpsw);
> -clean_unregister_netdev:
> -	cpsw_unregister_ports(cpsw);
>  clean_cpts:
>  	cpts_release(cpsw->cpts);
>  	cpdma_ctlr_destroy(cpsw->dma);

-- 
Alexander Sverdlin.