netdev - RE: [Intel-wired-lan] [PATCH iwl-next v1] ixgbe: refactor: use DECLARE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6241CE83E79C25C8E17DDE388B66A@IA1PR11MB6241.namprd11.prod.outlook.com>
Date: Fri, 6 Feb 2026 10:40:39 +0000
From: "Rinitha, SX" <sx.rinitha@...el.com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Loktionov, Aleksandr"
	<aleksandr.loktionov@...el.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Marcin Szycik
	<marcin.szycik@...ux.intel.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v1] ixgbe: refactor: use
 DECLARE_BITMAP for ring state field

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Aleksandr Loktionov
> Sent: 22 January 2026 14:21
> To: intel-wired-lan@...ts.osuosl.org; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Loktionov, Aleksandr <aleksandr.loktionov@...el.com>
> Cc: netdev@...r.kernel.org; Marcin Szycik <marcin.szycik@...ux.intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1] ixgbe: refactor: use DECLARE_BITMAP for ring state field
>
> Convert the ring state field from 'unsigned long' to a proper bitmap using DECLARE_BITMAP macro, aligning with the implementation pattern already used in the i40e driver.
>
> This change:
> - Adds __IXGBE_RING_STATE_NBITS as the bitmap size sentinel to enum
>  ixgbe_ring_state_t (consistent with i40e's __I40E_RING_STATE_NBITS)
> - Changes 'unsigned long state' to 'DECLARE_BITMAP(state,
> __IXGBE_RING_STATE_NBITS)' in struct ixgbe_ring
> - Removes the address-of operator (&) when passing ring->state to bit
>  manipulation functions, as bitmap arrays naturally decay to pointers
>
> The change maintains functional equivalence while using the more appropriate kernel bitmap API, consistent with other Intel Ethernet drivers.
>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Reviewed-by: Marcin Szycik <marcin.szycik@...ux.intel.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe.h      | 27 ++++-----
> drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c  |  4 +-  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 56 +++++++++----------  drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c  |  2 +-
> 4 files changed, 45 insertions(+), 44 deletions(-)
>

Tested-by: Rinitha S <sx.rinitha@...el.com> (A Contingent worker at Intel)