netdev - Re: [PATCH] [net-next] hinic3: select CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ea3ab8b-6b12-4741-b442-b41a396ec9ad@linux.dev>
Date: Fri, 6 Feb 2026 12:54:24 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Arnd Bergmann <arnd@...nel.org>, Fan Gong <gongfan1@...wei.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Zhu Yikai <zhuyikai1@...artners.com>
Cc: Arnd Bergmann <arnd@...db.de>, Xin Guo <guoxin09@...wei.com>,
 Gur Stavi <gur.stavi@...wei.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [net-next] hinic3: select CONFIG_DIMLIB

On 05/02/2026 16:13, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The driver started using dimlib but fails to select the corresponding
> symbol, which results in a link failure:
> 
> x86_64-linux-ld: drivers/net/ethernet/huawei/hinic3/hinic3_irq.o: in function `hinic3_poll':
> hinic3_irq.c:(.text+0x179): undefined reference to `net_dim'
> x86_64-linux-ld: drivers/net/ethernet/huawei/hinic3/hinic3_irq.o: in function `hinic3_rx_dim_work':
> hinic3_irq.c:(.text+0x1fb): undefined reference to `net_dim_get_rx_moderation'
> 
> Fixes: b35a6fd37a00 ("hinic3: Add adaptive IRQ coalescing with DIM")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/net/ethernet/huawei/hinic3/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/huawei/hinic3/Kconfig b/drivers/net/ethernet/huawei/hinic3/Kconfig
> index ce4331d1387b..02d6f91a7f4a 100644
> --- a/drivers/net/ethernet/huawei/hinic3/Kconfig
> +++ b/drivers/net/ethernet/huawei/hinic3/Kconfig
> @@ -11,6 +11,7 @@ config HINIC3
>   	depends on X86 || ARM64 || COMPILE_TEST
>   	depends on PCI_MSI && 64BIT
>   	select AUXILIARY_BUS
> +	select DIMLIB
>   	select PAGE_POOL
>   	help
>   	  This driver supports HiNIC 3rd gen Network Adapter (HINIC3).

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>