netdev - RFC: stmmac RSS support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <aYd4BkAeNW6d0iIC@shell.armlinux.org.uk>
Date: Sat, 7 Feb 2026 17:36:06 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
	Jose Abreu <joabreu@...opsys.com>
Cc: Maxime Chevallier <maxime.chevallier@...tlin.com>,
	Thierry Reding <treding@...dia.com>,
	Paritosh Dixit <paritoshd@...dia.com>
Subject: RFC: stmmac RSS support

Hi,

While looking at the possibilities of minimising the memory that
struct plat_stmmacenet_data consumes (880 bytes presently on
aarch64), I came across the RSS feature in stmmac.

In commit 76067459c686 ("net: stmmac: Implement RSS and enable it in
XGMAC core"), support was added for RSS to the core stmmac driver for
the dwxgmac2 core. I can only find socfpga and tegra as the two
platform glues that use the dwxgmac2 core.

RSS support is only enabled when both the core supports it, and the
platform glue sets priv->plat->rss_en.

However, the stmmac-related results of grepping for this member do not
show any platform glues which set this flag:

$ git grep '\<rss_en\>'
Documentation/networking/device_drivers/ethernet/stmicro/stmmac.rst:        int rss_en;
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:      if (!priv->dma_cap.rssen || !priv->plat->rss_en) {
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:      if (priv->dma_cap.rssen && priv->plat->rss_en)

So, as no one has decided to enable this feature during the intervening
six years, is there any benefit to having this code in the mainline
kernel, or should this feature be dropped?

If a user appears, the code will remain in git history and could be
restored.

Thoughts?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!