netdev - Re: [PATCH V2 net] net: hns3: fix double free issue for tx spare buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <177044040658.1192787.9336634399183206608.git-patchwork-notify@kernel.org>
Date: Sat, 07 Feb 2026 05:00:06 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Jijie Shao <shaojijie@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 shenjian15@...wei.com, liuyonglong@...wei.com, chenhao418@...wei.com,
 lantao5@...wei.com, huangdonghua3@...artners.com,
 yangshuaisong@...artners.com, jonathan.cameron@...wei.com,
 salil.mehta@...wei.com, jacob.e.keller@...el.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 net] net: hns3: fix double free issue for tx spare
 buffer

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu, 5 Feb 2026 20:17:19 +0800 you wrote:
> From: Jian Shen <shenjian15@...wei.com>
> 
> In hns3_set_ringparam(), a temporary copy (tmp_rings) of the ring structure
> is created for rollback. However, the tx_spare pointer in the original
> ring handle is incorrectly left pointing to the old backup memory.
> 
> Later, if memory allocation fails in hns3_init_all_ring() during the setup,
> the error path attempts to free all newly allocated rings. Since tx_spare
> contains a stale (non-NULL) pointer from the backup, it is mistaken for
> a newly allocated buffer and is erroneously freed, leading to a double-free
> of the backup memory.
> 
> [...]

Here is the summary with links:
  - [V2,net] net: hns3: fix double free issue for tx spare buffer
    https://git.kernel.org/netdev/net/c/6d2f142b1e4b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html