netdev - Re: [net-next,v2] bnge/bng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260207051422.4181717-1-kuba@kernel.org>
Date: Fri,  6 Feb 2026 21:14:22 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: vikas.gupta@...adcom.com
Cc: Jakub Kicinski <kuba@...nel.org>,
	andrew+netdev@...n.ch,
	bhargava.marreddy@...adcom.com,
	siva.kallam@...adcom.com,
	vsrama-krishna.nemani@...adcom.com,
	horms@...nel.org,
	jgg@...dia.com,
	pabeni@...hat.com,
	linux-kernel@...r.kernel.org,
	linux-rdma@...r.kernel.org,
	leonro@...dia.com,
	edumazet@...gle.com,
	netdev@...r.kernel.org,
	davem@...emloft.net,
	michael.chan@...adcom.com,
	ajit.khaparde@...adcom.com,
	rajashekar.hudumula@...adcom.com,
	pavan.chebbi@...adcom.com
Subject: Re: [net-next,v2] bnge/bng_re: Add a new HSI

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
bnge/bng_re: Add a new HSI

This commit adds a new HSI (Hardware Software Interface) for the BNGE and
ThorUltra RoCE drivers. The HSI is automatically generated and shared between
firmware and driver, replacing the existing BNXT HSI references.

> diff --git a/drivers/infiniband/hw/bng_re/bng_roce_hsi.h b/drivers/infiniband/hw/bng_re/bng_roce_hsi.h
> new file mode 100644
> index 000000000000..1c4666eb0c87
> --- /dev/null
> +++ b/drivers/infiniband/hw/bng_re/bng_roce_hsi.h
> @@ -0,0 +1,6450 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2026 Broadcom */
> +
> +/* DO NOT MODIFY!!! This file is automatically generated. */
> +
> +#ifndef __BNG_RE_HSI_H__
> +#define __BNG_RE_HSI_H__

[ ... ]

> +};
> +
> +#endif /* _ROCE_HSI_H_ */
           ^^^^^^^^^^^^^^^^

This isn't a bug, but the include guard comment doesn't match the actual macro
name. The file opens with '__BNG_RE_HSI_H__' but closes with a comment
referencing '_ROCE_HSI_H_'. The closing comment should read
'/* __BNG_RE_HSI_H__ */' to match.

While this doesn't affect compilation, it creates confusion for developers.
Compare with the related include/linux/bnge/hsi.h which correctly uses
matching guards throughout.
-- 
pw-bot: cr