netdev - Re: [PATCH net-next v5 2/2] virtio_net: add page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4a76ce5-9675-488f-a8f4-0f0541024d00@meta.com>
Date: Fri, 6 Feb 2026 21:25:25 -0800
From: Vishwanath Seshagiri <vishs@...a.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "Michael S . Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>,
        Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
        Eugenio Pérez
 <eperezma@...hat.com>,
        Andrew Lunn <andrew+netdev@...n.ch>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
        David Wei <dw@...idwei.uk>, Matteo Croce <technoboy85@...il.com>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>, netdev@...r.kernel.org,
        virtualization@...ts.linux.dev, linux-kernel@...r.kernel.org,
        kernel-team@...a.com
Subject: Re: [PATCH net-next v5 2/2] virtio_net: add page_pool support for
 buffer allocation



On 2/6/26 8:41 PM, Jakub Kicinski wrote:
> On Thu, 5 Feb 2026 16:27:15 -0800 Vishwanath Seshagiri wrote:
>> +	page = page_pool_alloc_frag(rq->page_pool, &offset, len + room, gfp);
>> +	if (unlikely(!page))
>>   		return -ENOMEM;
>>   
>> +	buf = page_address(page) + offset;
> 
> Please take a look at page_pool_alloc_va()
> 
> I mean all the way down until you reach page_pool_alloc_netmem()
> and realize the helper you're adding in patch 1 is a solved problem

I apologize for adding patch 1. I will use page_pool_alloc_va and send
v6 with only patch 2.