netdev - Re: [PATCH net-next v20 00/12] virtio_net: Add ethtool flow rules support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c96d6b1c-5bad-4e06-905c-10f722c9b9d1@nvidia.com>
Date: Sat, 7 Feb 2026 07:14:25 -0600
From: Dan Jurgens <danielj@...dia.com>
To: "Michael S. Tsirkin" <mst@...hat.com>, Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, jasowang@...hat.com, pabeni@...hat.com,
 virtualization@...ts.linux.dev, parav@...dia.com, shshitrit@...dia.com,
 yohadt@...dia.com, xuanzhuo@...ux.alibaba.com, eperezma@...hat.com,
 jgg@...pe.ca, kevin.tian@...el.com, andrew+netdev@...n.ch,
 edumazet@...gle.com
Subject: Re: [PATCH net-next v20 00/12] virtio_net: Add ethtool flow rules
 support

On 2/7/26 4:01 AM, Michael S. Tsirkin wrote:
> On Thu, Feb 05, 2026 at 06:43:28PM -0800, Jakub Kicinski wrote:
>> On Thu, 5 Feb 2026 16:46:55 -0600 Daniel Jurgens wrote:
>>> This series implements ethtool flow rules support for virtio_net using the
>>> virtio flow filter (FF) specification. The implementation allows users to
>>> configure packet filtering rules through ethtool commands, directing
>>> packets to specific receive queues, or dropping them based on various
>>> header fields.
>>
>> This is a 4th version of this you posted in as many days and it doesn't
>> even build. Please slow down. Please wait with v21 until after the merge
>> window. We have enough patches to sift thru still for v7.0.
> 
> v20 and no end in sight.
> Just looking at the amount of pain all this parsing is inflicting
> makes me worry. And wait until we need to begin worrying about
> maintaining UAPI stability.
> 
> It would be much nicer if drivers were out of the business of parsing
> fiddly structures.  Isn't there a way for more code in net core
> to deal with all this?

MST, you reviewed the spec that defined these data structures. If you
didn't want the driver to have parse data structures then suggesting
using the same format as the ethtool flow specs would have been a great
idea at that point. Or short of that padded and fixed size data
structures would also made things much cleaner.

I thought this series was close to done, so I was trying to address the
very non-deterministic AI review comments. It's been generating new
comments on things that had been there for many revisions, and running
it locally with the same model never reproduces the comments from the
online review.