netdev - Re: [PATCH net-next v2 1/9] eth: bnxt: gather and report HW-GRO stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLimgibJ0qkM1AacZVh8MKKy-pE_AAc4KPKZ7GUqebmXW9A@mail.gmail.com>
Date: Sat, 7 Feb 2026 16:09:13 -0800
From: Michael Chan <michael.chan@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, shuah@...nel.org, 
	willemb@...gle.com, petrm@...dia.com, donald.hunter@...il.com, 
	pavan.chebbi@...adcom.com, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/9] eth: bnxt: gather and report HW-GRO stats

On Fri, Feb 6, 2026 at 4:35 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Count and report HW-GRO stats as seen by the kernel.
> The device stats for GRO seem to not reflect the reality,
> perhaps they count sessions which did not actually result
> in any aggregation. Also they count wire packets, so we
> have to count super-frames, anyway.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Michael Chan <michael.chan@...adcom.com>

I'm suggesting a minor naming change below if you need to do v3.

> @@ -13492,6 +13497,8 @@ static void bnxt_get_one_ring_err_stats(struct bnxt *bp,

With the new GRO counters, this function is no longer limited to error
stats.  So maybe rename it to something like
bnxt_get_one_ring_misc_stats()?

>         stats->rx_total_netpoll_discards += sw_stats->rx.rx_netpoll_discards;
>         stats->rx_total_ring_discards +=
>                 BNXT_GET_RING_STATS64(hw_stats, rx_discard_pkts);
> +       stats->rx_total_hw_gro_packets += sw_stats->rx.rx_hw_gro_packets;
> +       stats->rx_total_hw_gro_wire_packets += sw_stats->rx.rx_hw_gro_wire_packets;
>         stats->tx_total_resets += sw_stats->tx.tx_resets;
>         stats->tx_total_ring_discards +=
>                 BNXT_GET_RING_STATS64(hw_stats, tx_discard_pkts);

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5469 bytes)