netdev - Re: [PATCH net-next 1/2] bnxt_en: Refactor bnxt_need_reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYpeBvldHPDI7N/F@devvm20253.cco0.facebook.com>
Date: Mon, 9 Feb 2026 14:21:58 -0800
From: Joe Damato <joe@...a.to>
To: Michael Chan <michael.chan@...adcom.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, andrew+netdev@...n.ch,
	pavan.chebbi@...adcom.com, andrew.gospodarek@...adcom.com
Subject: Re: [PATCH net-next 1/2] bnxt_en: Refactor bnxt_need_reserve_rings()

On Sat, Feb 07, 2026 at 03:51:17PM -0800, Michael Chan wrote:
> bnxt_need_reserve_rings() checks 6 ring resources against the reserved
> values to determine if a new reservation is needed.  Factor out the code
> to collect the total resources into a new helper function
> bnxt_get_total_resources() to make the code cleaner and easier to read.
> Instead of individual scalar variables, use the struct bnxt_hw_rings to
> hold all the ring resources.  Using the struct, hwr.cp replaces the nq
> variable and the chip specific hwr.cp_p5 replaces cp on newer chips.
> 
> There is no change in behavior.  This will make it easier to check the
> RSS context resource in the next patch.
> 
> Reviewed-by: Andy Gospodarek <andrew.gospodarek@...adcom.com>
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 45 +++++++++++++++--------
>  1 file changed, 30 insertions(+), 15 deletions(-)

Reviewed-by: Joe Damato <joe@...a.to>