netdev - Re: [PATCH net-next v3 1/3] dt-bindings: net: dsa: lantiq,gswip: reference common PHY properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260209235413.GA2137170-robh@kernel.org>
Date: Mon, 9 Feb 2026 17:54:13 -0600
From: Rob Herring <robh@...nel.org>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Hauke Mehrtens <hauke@...ke-m.de>, Andrew Lunn <andrew@...n.ch>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 1/3] dt-bindings: net: dsa: lantiq,gswip:
 reference common PHY properties

On Sun, Feb 01, 2026 at 03:41:53AM +0000, Daniel Golle wrote:
> Reference the common PHY properties so RX and TX SerDes lane polarity
> of the SGMII/1000Base-X/2500Base-X port can be configured.
> 
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> ---
> v3: commit message: clarify that the intention is to configure polarity
>     at port level, as opposed to the internal polarity of the PCS component
> v2: use allOf to include PHY common properties, add example use
> ---
>  Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> index f601e5f9fa6a..b4a31cde4322 100644
> --- a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> @@ -105,6 +105,8 @@ patternProperties:
>      patternProperties:
>        "^(ethernet-)?port@[0-6]$":
>          $ref: dsa-port.yaml#
> +        allOf:
> +          - $ref: /schemas/phy/phy-common-props.yaml#

If you respin, put both $ref's under the allOf.

Acked-by: Rob Herring (Arm) <robh@...nel.org>

>          unevaluatedProperties: false
>  
>          properties:
> @@ -288,6 +290,7 @@ examples:
>  
>    - |
>      #include <dt-bindings/leds/common.h>
> +    #include <dt-bindings/phy/phy.h>
>  
>      mdio {
>          #address-cells = <1>;
> @@ -320,6 +323,7 @@ examples:
>                      label = "wan";
>                      phy-mode = "1000base-x";
>                      managed = "in-band-status";
> +                    tx-polarity = <PHY_POL_INVERT>;
>                  };
>  
>                  port@5 {
> -- 
> 2.52.0