netdev - Re: [PATCH net-next v3 05/11] net: phy: Create SFP phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260209162503.GA2478520@horms.kernel.org>
Date: Mon, 9 Feb 2026 16:25:03 +0000
From: Simon Horman <horms@...nel.org>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
Cc: davem@...emloft.net, Andrew Lunn <andrew@...n.ch>,
	Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Russell King <linux@...linux.org.uk>,
	Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Herve Codina <herve.codina@...tlin.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Köry Maincent <kory.maincent@...tlin.com>,
	Marek Behún <kabel@...nel.org>,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	Nicolò Veronese <nicveronese@...il.com>,
	mwojtas@...omium.org, Romain Gantois <romain.gantois@...tlin.com>,
	Daniel Golle <daniel@...rotopia.org>,
	Dimitri Fedrau <dimitri.fedrau@...bherr.com>
Subject: Re: [PATCH net-next v3 05/11] net: phy: Create SFP phy_port before
 registering usptream

On Tue, Feb 03, 2026 at 07:09:23PM +0100, Maxime Chevallier wrote:
> Hi Simon,
> 
> On 03/02/2026 18:52, Simon Horman wrote:
> 
> >> -	if (!ret && phydev->sfp_bus)
> >> -		ret = phy_setup_sfp_port(phydev);
> >> +	ret = sfp_bus_add_upstream(bus, phydev, &sfp_phydev_ops);
> >> +	sfp_bus_put(bus);
> >> +
> >> +	if (ret && port) {
> > 
> > Hi Maxime,
> > 
> > If bus is NULL then port will not be set here.
> 
> Arg... I though smatch was running in the NIPA ingst-mdir script, but I
> was wrong :(

FWWIW, I think it would be nice if it did.
But I'm also not sure how well it works when applied to a full
allmodconfig build. Which, AFAIK, is how NIPA tends to run.

> 
> I'll address that in V5 as the problme is still in V4, thank you for the
> report
> 
> Maxime
> 
> 
>