netdev - Re: [PATCH net-next] net/mlx5e: remove declarations of mlx5e_shampo_{fill_umr,dealloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a36c490a-0fcc-4fc5-b73a-6d6e0eba4e70@gmail.com>
Date: Tue, 10 Feb 2026 08:09:05 +0200
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Simon Horman <horms@...nel.org>, Saeed Mahameed <saeedm@...dia.com>,
 Leon Romanovsky <leon@...nel.org>, Tariq Toukan <tariqt@...dia.com>,
 Mark Bloch <mbloch@...dia.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next] net/mlx5e: remove declarations of
 mlx5e_shampo_{fill_umr,dealloc_hd}

On 06/02/2026 13:18, Simon Horman wrote:
> These functions were recently removed by commit 24cf78c73831
> ("net/mlx5e: SHAMPO, Switch to header memcpy"), however,
> their declarations were left behind.
> 
> This patch removes those declarations.
> 
> Flagged by review-prompts while I was exercising Orc mode locally.
> Compile tested only.
> 
> Signed-off-by: Simon Horman <horms@...nel.org>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> index 843f732e4eedb005eba58b9a9ebe48c6703906e5..a7de3a3efc49f6c237ea42b0b932fbe1f5aca847 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> @@ -1034,8 +1034,6 @@ void mlx5e_build_ptys2ethtool_map(void);
>   bool mlx5e_check_fragmented_striding_rq_cap(struct mlx5_core_dev *mdev, u8 page_shift,
>   					    enum mlx5e_mpwrq_umr_mode umr_mode);
>   
> -void mlx5e_shampo_fill_umr(struct mlx5e_rq *rq, int len);
> -void mlx5e_shampo_dealloc_hd(struct mlx5e_rq *rq);
>   void mlx5e_get_stats(struct net_device *dev, struct rtnl_link_stats64 *stats);
>   void mlx5e_fold_sw_stats64(struct mlx5e_priv *priv, struct rtnl_link_stats64 *s);
>   
> 
> 
> 
> 

Reviewed-by: Tariq Toukan <tariqt@...dia.com>
Thanks for your patch.