netdev - Re: [PATCH net-next 2/4] selftests/net: Export Netlink class via lib.py

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYyqe+R6EHlj7m6+@devvm11784.nha0.facebook.com>
Date: Wed, 11 Feb 2026 08:12:43 -0800
From: Bobby Eshleman <bobbyeshleman@...il.com>
To: David Wei <dw@...idwei.uk>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Joe Damato <joe@...a.to>, Wei Wang <weibunny@...a.com>,
	Stanislav Fomichev <sdf@...ichev.me>,
	Nikolay Aleksandrov <razor@...ckwall.org>
Subject: Re: [PATCH net-next 2/4] selftests/net: Export Netlink class via
 lib.py

On Tue, Feb 10, 2026 at 12:04:17PM -0800, David Wei wrote:
> Making rtnl newlink calls requires constants defined in Netlink class in
> pyynl. Export it.
> 
> Signed-off-by: David Wei <dw@...idwei.uk>
> ---
>  tools/testing/selftests/drivers/net/lib/py/__init__.py | 4 ++--
>  tools/testing/selftests/net/lib/py/__init__.py         | 4 ++--
>  tools/testing/selftests/net/lib/py/ynl.py              | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/lib/py/__init__.py b/tools/testing/selftests/drivers/net/lib/py/__init__.py
> index 8b75faa9af6d..a18e21069f7a 100644
> --- a/tools/testing/selftests/drivers/net/lib/py/__init__.py
> +++ b/tools/testing/selftests/drivers/net/lib/py/__init__.py
> @@ -19,7 +19,7 @@ try:
>      # Import one by one to avoid pylint false positives
>      from net.lib.py import NetNS, NetNSEnter, NetdevSimDev
>      from net.lib.py import EthtoolFamily, NetdevFamily, NetshaperFamily, \
> -        NlError, RtnlFamily, DevlinkFamily, PSPFamily
> +        NlError, RtnlFamily, DevlinkFamily, PSPFamily, Netlink
>      from net.lib.py import CmdExitFailure
>      from net.lib.py import bkg, cmd, bpftool, bpftrace, defer, ethtool, \
>          fd_read_timeout, ip, rand_port, wait_port_listen, wait_file
> @@ -31,7 +31,7 @@ try:
>  
>      __all__ = ["NetNS", "NetNSEnter", "NetdevSimDev",
>                 "EthtoolFamily", "NetdevFamily", "NetshaperFamily",
> -               "NlError", "RtnlFamily", "DevlinkFamily", "PSPFamily",
> +               "NlError", "RtnlFamily", "DevlinkFamily", "PSPFamily", "Netlink",
>                 "CmdExitFailure",
>                 "bkg", "cmd", "bpftool", "bpftrace", "defer", "ethtool",
>                 "fd_read_timeout", "ip", "rand_port",
> diff --git a/tools/testing/selftests/net/lib/py/__init__.py b/tools/testing/selftests/net/lib/py/__init__.py
> index f528b67639de..fec518c2a0dc 100644
> --- a/tools/testing/selftests/net/lib/py/__init__.py
> +++ b/tools/testing/selftests/net/lib/py/__init__.py
> @@ -15,7 +15,7 @@ from .nsim import NetdevSim, NetdevSimDev
>  from .utils import CmdExitFailure, fd_read_timeout, cmd, bkg, defer, \
>      bpftool, ip, ethtool, bpftrace, rand_port, wait_port_listen, wait_file, tool
>  from .ynl import NlError, YnlFamily, EthtoolFamily, NetdevFamily, RtnlFamily, RtnlAddrFamily
> -from .ynl import NetshaperFamily, DevlinkFamily, PSPFamily
> +from .ynl import NetshaperFamily, DevlinkFamily, PSPFamily, Netlink
>  
>  __all__ = ["KSRC",
>             "KsftFailEx", "KsftSkipEx", "KsftXfailEx", "ksft_pr", "ksft_eq",
> @@ -30,4 +30,4 @@ __all__ = ["KSRC",
>             "NetdevSim", "NetdevSimDev",
>             "NetshaperFamily", "DevlinkFamily", "PSPFamily", "NlError",
>             "YnlFamily", "EthtoolFamily", "NetdevFamily", "RtnlFamily",
> -           "RtnlAddrFamily"]
> +           "RtnlAddrFamily", "Netlink"]
> diff --git a/tools/testing/selftests/net/lib/py/ynl.py b/tools/testing/selftests/net/lib/py/ynl.py
> index 32c223e93b2c..a52b067f7589 100644
> --- a/tools/testing/selftests/net/lib/py/ynl.py
> +++ b/tools/testing/selftests/net/lib/py/ynl.py
> @@ -13,14 +13,14 @@ try:
>          SPEC_PATH = KSFT_DIR / "net/lib/specs"
>  
>          sys.path.append(tools_full_path.as_posix())
> -        from net.lib.ynl.pyynl.lib import YnlFamily, NlError
> +        from net.lib.ynl.pyynl.lib import YnlFamily, NlError, Netlink
>      else:
>          # Running in tree
>          tools_full_path = KSRC / "tools"
>          SPEC_PATH = KSRC / "Documentation/netlink/specs"
>  
>          sys.path.append(tools_full_path.as_posix())
> -        from net.ynl.pyynl.lib import YnlFamily, NlError
> +        from net.ynl.pyynl.lib import YnlFamily, NlError, Netlink
>  except ModuleNotFoundError as e:
>      ksft_pr("Failed importing `ynl` library from kernel sources")
>      ksft_pr(str(e))
> -- 
> 2.47.3
> 

Reviewed-by: Bobby Eshleman <bobbyeshleman@...a.com>