netdev - Re: [PATCH net-next v4 2/4] selftests/net: add no ARP b/mcast,null poison test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+3n-TpV8pg9exk15vGpPX3OW1-k-pLSiixUZ2UEvbFOgcc0+g@mail.gmail.com>
Date: Wed, 11 Feb 2026 19:29:01 +0100
From: Marc Sune <marcdevel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4 2/4] selftests/net: add no ARP b/mcast,null
 poison test

Missatge de Jakub Kicinski <kuba@...nel.org> del dia dc., 11 de febr.
2026 a les 3:11:
>
> On Sat,  7 Feb 2026 21:40:34 +0100 Marc Suñé wrote:
> > diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> > index afdea6d95bde..c6d571bf72be 100644
> > --- a/tools/testing/selftests/net/Makefile
> > +++ b/tools/testing/selftests/net/Makefile
> > @@ -11,6 +11,7 @@ TEST_PROGS := \
> >       amt.sh \
> >       arp_ndisc_evict_nocarrier.sh \
> >       arp_ndisc_untracked_subnets.sh \
> > +     arp_no_invalid_sha_poision.sh \
> >       bareudp.sh \
> >       big_tcp.sh \
> >       bind_bhash.sh \
>
> Not sure why but we get:
>
> # selftests: net: arp_no_invalid_sha_poision.sh
> # Warning: file arp_no_invalid_sha_poision.sh is missing!
> not ok 1 selftests: net: arp_no_invalid_sha_poision.sh
>
> When we run
>         make TARGETS=net run_tests
>

It seems to work for me (typo already fixed):

sudo make TARGETS=net run_tests

[...]

# timeout set to 3600
# selftests: net: arp_no_invalid_sha_poison.sh
# TEST: 1.1  ARP no poisoning dmac=bcast reply sha=bcast              [ OK ]
# TEST: 1.2  ARP no poisoning dmac=bcast reply sha=null               [ OK ]
# TEST: 1.3  ARP no poisoning dmac=bcast req   sha=bcast              [ OK ]
# TEST: 1.4  ARP no poisoning dmac=bcast req   sha=null               [ OK ]
# TEST: 1.5  ARP no poisoning dmac=bcast req   sha=mcast              [ OK ]
# TEST: 1.6  ARP no poisoning dmac=bcast reply sha=mcast              [ OK ]
# TEST: 1.7  ARP no poisoning dmac=veth0 reply sha=bcast              [ OK ]
# TEST: 1.8  ARP no poisoning dmac=veth0 reply sha=null               [ OK ]
# TEST: 1.9  ARP no poisoning dmac=veth0 req   sha=bcast              [ OK ]
# TEST: 1.10 ARP no poisoning dmac=veth0 req   sha=null               [ OK ]
# TEST: 1.11 ARP no poisoning dmac=veth0 req   sha=mcast              [ OK ]
# TEST: 1.12 ARP no poisoning dmac=veth0 reply sha=mcast              [ OK ]
ok 25 selftests: net: arp_no_invalid_sha_poison.sh

Not sure why you are getting this error, and why selftests didn't fail
in any of the 4 versions in patchwork. I assume tests run there too.

> The word "poison" is misspelled but both in the file name and makefile.
> I guess there's another typo somewhere.

Sigh. Let me fix that, along with your comment on patch 4
(TEST_GEN_FILES vs. _PROGS) on the other thread. I will also fix some
AI review warnings (error traces) on patch 4 that AI reviews _now_
highlighted. It seems AI reviews are non deterministic, as
ndisc_send.c didn't change since v2, and the patch didn't even change
v3->v4.

I guess you'd like me to wait till net-next is open again, correct?

Thank you for the guidance Jakub.