phc-discussions - Re: [PHC] catena.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 28 Jan 2014 10:12:32 +0100
From: Christian Forler <christian.forler@...-weimar.de>
To: discussions@...sword-hashing.net
Subject: Re: [PHC] catena.c

On 28.01.2014 04:17, Solar Designer wrote:
> Christian,
> 
> I guess the 128 constant in the snippet below was meant to be H_LEN,
> since otherwise behavior will differ for H_LEN != 64, and it could even
> be over-read beyond the malloc()'ed memory.

It should be 2*H_LEN since we want to compute

p[i] <-- Hash( p[i-1] || p[i]).

Thanks for this informal "bug" report. :-)

Best regards,
Christian


Download attachment "signature.asc" of type "application/pgp-signature" (535 bytes)