phc-discussions - Re: [PHC] gambit pseudo code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1594254286.194175.1397495542251.open-xchange@email.1and1.com>
Date: Mon, 14 Apr 2014 12:12:22 -0500 (CDT)
From: Steve Thomas <steve@...tu.com>
To: discussions@...sword-hashing.net
Subject: Re: [PHC] gambit pseudo code

> On April 14, 2014 at 11:47 AM Krisztián Pintér <pinterkr@...il.com> wrote:
>
> i kind of know that i'm exceeding my allowed email count per day. but
> i just noticed that gambit pseudo code is on line.
>
> at a glance, i mostly agree to it, and nice work. will check more
> thoroughly later.
>
> one observation. STR_TO_LE_ARRAY and LE_ARRAY_TO_STR assumes little
> endian, but in fact the only thing that potentially cares about
> endianness is the Trans function. otherwise, we just store and
> restore, which is endian neutral.
>
> not sure if it worth noted or something.

Fixed:
# STR_TO_LE_ARRAY *        Converts a string to a WORD_SIZE little endian
integer array
# LE_ARRAY_TO_STR *        Converts a WORD_SIZE little endian integer array to a
string
...
# * These can be endian agnostic unless transform() is used in a way that
endianness
#   matters.