lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 31 Mar 2015 15:02:06 +0200
From: Dmitry Khovratovich <khovratovich@...il.com>
To: "discussions@...sword-hashing.net" <discussions@...sword-hashing.net>
Subject: Re: [PHC] Argon2

Yes, you're right, the code is little-endian only so far (the
specification implicitly suggest little-endianness in the
initialization phase). This must be changed, and I will do it.

Dmitry

On Tue, Mar 31, 2015 at 2:53 PM, Solar Designer <solar@...nwall.com> wrote:
> Hi Dmitry,
>
> One other detail I noticed yesterday, but forgot to mention: the current
> Argon2 code appears to be endianness-sensitive, at least here:
>
>         blake2b_update(&BlakeHash, (const uint8_t*)&lanes, sizeof(lanes));
>         blake2b_update(&BlakeHash, (const uint8_t*)&outlen, sizeof(outlen));
>         blake2b_update(&BlakeHash, (const uint8_t*)&m_cost, sizeof(m_cost));
>         blake2b_update(&BlakeHash, (const uint8_t*)&t_cost, sizeof(t_cost));
>         blake2b_update(&BlakeHash, (const uint8_t*)&version, sizeof(version));
>         blake2b_update(&BlakeHash, (const uint8_t*)&msglen, sizeof(msglen));
>         blake2b_update(&BlakeHash, (const uint8_t*)msg, msglen);
>         blake2b_update(&BlakeHash, (const uint8_t*)&noncelen, sizeof(noncelen));
>         blake2b_update(&BlakeHash, (const uint8_t*)nonce, noncelen);
>         blake2b_update(&BlakeHash, (const uint8_t*)&secretlen, sizeof(secretlen));
>         blake2b_update(&BlakeHash, (const uint8_t*)secret, secretlen);
>         blake2b_update(&BlakeHash, (const uint8_t*)&adlen, sizeof(adlen));
>         blake2b_update(&BlakeHash, (const uint8_t*)ad, adlen);
>
> Perhaps you're aware of this, and simply didn't improve the code yet.
>
> Alexander



-- 
Best regards,
Dmitry Khovratovich

Powered by blists - more mailing lists