phc-discussions - Re: [PHC] Bug in yescrypt pwxform specification pseudocode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 14 Apr 2015 19:16:26 -0400 (EDT)
From: Ken T Takusagawa <kenta@....edu>
To: discussions@...sword-hashing.net
Subject: Re: [PHC] Bug in yescrypt pwxform specification pseudocode

On Tue, 14 Apr 2015, Solar Designer wrote:

> As to fixing this, maybe the rounds loop should go from 1 to PWXrounds
> in the spec, whereas implementations may also make it from 0 to
> PWXrounds-1 (or even use a "do ... while (--count)" loop, or an unrolled
> loop).  

Because the index variable "i" is not used within the loop, 
I think the pseudocode would be clearer if it simply said, 
"Repeat PWXrounds times:".

> The code is correct as-is, so there won't be a change to that

The pseudocode is present in the comments of the code.

--ken