phc-discussions - Re: [PHC] Argon2 version 1.2.1 release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 26 Aug 2015 17:53:20 +0200
From: Dmitry Khovratovich <khovratovich@...il.com>
To: "discussions@...sword-hashing.net" <discussions@...sword-hashing.net>
Subject: Re: [PHC] Argon2 version 1.2.1 release

Hi Bill, thanks for the comments. Any code review is much appreciated.

On Wed, Aug 26, 2015 at 5:44 PM, Bill Cox <waywardgeek@...il.com> wrote:

>
>
> - The types Argon2_i, Argon2_d, etc, should be commented in the code.  Few
> programmers will bother reading the documentation, so the code has to be
> understandable on it's own.  There needs to be some comments to help the
> programmer decide which to call.
>

True. We'll add that


>
> - I think the Argon2_id mode is currently equivalent to Argon2_d.  There's
> no place in the reference code where Argon2_id is used.  The reason the
> vectors are different is probably because the type is hashed into the
> initial derived key, as it should be.
>

Oops, it is a bug, the Argon2_id code got lost somewhere on the way. Will
fix ASAP.


>
> Overall, this seems like outstanding work.  Thanks to everyone in the
> Argon2 team for delivering a first rate solution!
>
> Bill
>



-- 
Best regards,
Dmitry Khovratovich

Content of type "text/html" skipped