phc-discussions - Re: Comments on Argon2 v1.2.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAEkTiScRNDyB4G1Tvk5=aWmA7ZcPv9EHiMbS+MWNjFgDsFA1A@mail.gmail.com>
Date: Sat, 5 Sep 2015 21:49:24 -0700
From: Andrew Ekstedt <andrew.ekstedt@...il.com>
To: discussions@...sword-hashing.net
Subject: Re: Comments on Argon2 v1.2.1

Another bug (and a typo!):

Section 3.3 describes how to derive a block of indices for Argon2i by
running G² on a bunch of inputs including:

>     • i is is the counter starting in each segment from 0

Typo: "is is" (and "tWe", on the next line.)

Bug: The reference implementation starts the counter from 1 instead of 0.

https://github.com/khovratovich/Argon2/blob/f80a42fdb51e8cd615f9388baad1401b9da66103/Source/Core/argon2-ref-core.cpp#L81
https://github.com/khovratovich/Argon2/blob/f80a42fdb51e8cd615f9388baad1401b9da66103/Source/Core/argon2-opt-core.cpp#L154

Andrew Ekstedt