linux-ext4 - Re: [PATCH 3/4] e2fsprogs: Make mke2fs use undo I/O manager.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 01 Aug 2007 11:44:01 +0530
From:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
To:	Andreas Dilger <adilger@...sterfs.com>
CC:	tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 3/4] e2fsprogs: Make mke2fs use undo I/O manager.



Andreas Dilger wrote:
> On Aug 01, 2007  07:34 +0530, Aneesh Kumar K.V wrote:
>> When running mke2fs, if a file system is detected
>> on the device, we use Undo I/O manager as the io manager.
>> This helps in reverting the changes made to the filesystem
>> in case we wrongly selected the device.
>>
>> The environment variable MKE2FS_SCRATCH_DIR
>> is used to indicate the  directory within which the tdb
>> file need to be created. The file will be named mke2fs-XXXXXX
> 
> It might be more useful to have "mke2fs-{dev}-{timestamp}" as
> the filename, so that it is clear where the image came from.
>

I added it as a FIXME!! in the code. So i was intending to do it.

+	/* FIXME!! Should we generate Unique file name ?? */
+	sprintf(tdb_file, "%s/mke2fs-XXXXXX", tdb_dir);



I will add it in my next patch set.

-aneesh
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html