linux-ext4 - Re: [RFC][PATCH 2/3] ext4 online defrag (ver 0.7)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 06 Mar 2008 10:36:28 -0600
From:	Eric Sandeen <sandeen@...hat.com>
To:	Akira Fujita <a-fujita@...jp.nec.com>
CC:	Andreas Dilger <adilger@....com>, tytso@....edu, cmm@...ibm.com,
	linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [RFC][PATCH 2/3] ext4 online defrag (ver 0.7)

Akira Fujita wrote:
> Hi Andreas,
>> On Mar 06, 2008  09:01 +0900, Akira Fujita wrote:
>>   
>>> Change the name of functions (ext4_ext_xxx -> ext4_defrag_xxx)
>>> and some cleanups.
>>>
>>> -int ext4_ext_walk_space(struct inode *inode, ext4_lblk_t block,
>>> -			ext4_lblk_t num, ext_prepare_callback func,
>>> -			void *cbdata)
>>> -{
>>>     
>> We were just going to be using this function for the FIEMAP support.
>> I think there are several other functions which are not specific
>> to defrag, so they shouldn't be renamed to be defrag specific.
>>   
> 
> ext4_ext_walk_space is no longer used by ext4 online defrag.
> So I just removed from defrag.c not renamed.
> 
> Shouldn't I remove ext4_ext_walk_space from defrag
> for support FIEMAP?
> I think it should be moved to extents.c

I agree.  I'm working on FIEMAP, and I'll put it back into extents.c
along with the FIEMAP patch, if you don't need it for defrag.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html