[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 8 Aug 2006 15:22:34 +0300
From: Muli Ben-Yehuda <muli@...ibm.com>
To: Björn Steinbrink <B.Steinbrink@....de>
Cc: Shem Multinymous <multinymous@...il.com>,
Pavel Machek <pavel@...e.cz>, Robert Love <rlove@...ve.org>,
Jean Delvare <khali@...ux-fr.org>,
Greg Kroah-Hartman <gregkh@...e.de>,
Alan Cox <alan@...rguk.ukuu.org.uk>,
linux-kernel@...r.kernel.org, hdaps-devel@...ts.sourceforge.net
Subject: Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
On Mon, Aug 07, 2006 at 08:20:47PM +0200, Björn Steinbrink wrote:
> On 2006.08.07 19:30:55 +0300, Shem Multinymous wrote:
> > Hi Pavel,
> >
> > On 8/7/06, Pavel Machek <pavel@...e.cz> wrote:
> > >> + int total, ret;
> > >> + for (total=READ_TIMEOUT_MSECS; total>0; total-=RETRY_MSECS) {
> > >
> > >Could we go from 0 to timeout, not the other way around?
> >
> > Sure.
> > (That's actually vanilla hdapsd code, moved around...)
>
> Maybe you could convert that to sth. like this along the way?
>
> int ret;
> unsigned long timeout = jiffies + msec_to_jiffies(READ_TIMEOUT_MSECS);
> for (;;) {
> ret = thinkpad_ec_lock();
> if (ret)
> return ret;
Just in case someone was going to cut and paste, this will return with
the ec_lock taken.
Cheers,
Muli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists