[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 8 Aug 2006 17:25:59 +0100
From: Christoph Hellwig <hch@...radead.org>
To: Ananth N Mavinakayanahalli <ananth@...ibm.com>
Cc: linux-kernel@...r.kernel.org,
Prasanna S Panchamukhi <prasanna@...ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
Jim Keniston <jkenisto@...ibm.com>
Subject: Re: [PATCH 2/3] Kprobes: Define retval helper
On Mon, Aug 07, 2006 at 05:30:24PM +0530, Ananth N Mavinakayanahalli wrote:
> From: Ananth N Mavinakayanahalli <ananth@...ibm.com>
>
> Add the KPROBE_RETVAL macro to help extract the return value on
> different architectures, while using function-return probes.
Good idea. You should add parentheses around regs, otherwise the C
preprocessor might bite users. Also the shouting name is quite ugly.
In fact it should probably go to asm/system.h or similar and not have
a kprobes name - it just extracts the return value from a struct pt_regs
after all.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists