linux-kernel - Re: [PATCH] ipmi_si_intf.c: fix "&& 0xff" typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Nov 2006 16:15:46 -0600
From:	Corey Minyard <minyard@....org>
To:	Alexey Dobriyan <adobriyan@...il.com>
CC:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi_si_intf.c: fix "&& 0xff" typos

Ouch, I guess we've never had a system with these address types.  Thanks.

-Corey

Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> ---
>
>  drivers/char/ipmi/ipmi_si_intf.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -1211,7 +1211,7 @@ static void intf_mem_outb(struct si_sm_i
>  static unsigned char intf_mem_inw(struct si_sm_io *io, unsigned int offset)
>  {
>  	return (readw((io->addr)+(offset * io->regspacing)) >> io->regshift)
> -		&& 0xff;
> +		& 0xff;
>  }
>  
>  static void intf_mem_outw(struct si_sm_io *io, unsigned int offset,
> @@ -1223,7 +1223,7 @@ static void intf_mem_outw(struct si_sm_i
>  static unsigned char intf_mem_inl(struct si_sm_io *io, unsigned int offset)
>  {
>  	return (readl((io->addr)+(offset * io->regspacing)) >> io->regshift)
> -		&& 0xff;
> +		& 0xff;
>  }
>  
>  static void intf_mem_outl(struct si_sm_io *io, unsigned int offset,
> @@ -1236,7 +1236,7 @@ #ifdef readq
>  static unsigned char mem_inq(struct si_sm_io *io, unsigned int offset)
>  {
>  	return (readq((io->addr)+(offset * io->regspacing)) >> io->regshift)
> -		&& 0xff;
> +		& 0xff;
>  }
>  
>  static void mem_outq(struct si_sm_io *io, unsigned int offset,
>   

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/