linux-kernel - Re: [PATCH] ipmi_si_intf.c: fix "&& 0xff" typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Nov 2006 23:49:40 -0500
From:	Valdis.Kletnieks@...edu
To:	Corey Minyard <minyard@....org>
Cc:	Alexey Dobriyan <adobriyan@...il.com>,
	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi_si_intf.c: fix "&& 0xff" typos

On Wed, 08 Nov 2006 16:15:46 CST, Corey Minyard said:
> Ouch, I guess we've never had a system with these address types.  Thanks.

If we never had a system with these address types..

> >  static unsigned char intf_mem_inw(struct si_sm_io *io, unsigned int offset)
> >  {
> >  	return (readw((io->addr)+(offset * io->regspacing)) >> io->regshift)
> > -		&& 0xff;
> > +		& 0xff;
> >  }

Is this dead code that isn't called by anybody?

Content of type "application/pgp-signature" skipped