linux-kernel - RE: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 Feb 2008 18:29:06 -0800
From:	"Nelson, Shannon" <shannon.nelson@...el.com>
To:	"Brice Goglin" <Brice.Goglin@...ia.fr>,
	"Williams, Dan J" <dan.j.williams@...el.com>
Cc:	"Leech, Christopher" <christopher.leech@...el.com>,
	"LKML" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

>-----Original Message-----
>From: Brice Goglin [mailto:Brice.Goglin@...ia.fr] 
>Sent: Wednesday, February 13, 2008 1:05 PM
>To: Nelson, Shannon; Williams, Dan J
>Cc: Leech, Christopher; LKML
>Subject: [PATCH][I/OAT]: Remove duplicate assignation in 
>dma_skb_copy_datagram_iovec
>
>[I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec
>
>No need to compute copy twice in the frags loop in
>dma_skb_copy_datagram_iovec().
>
>Signed-off-by: Brice Goglin <Brice.Goglin@...ia.fr>
>---
> user_dma.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/net/core/user_dma.c b/net/core/user_dma.c
>index 0ad1cd5..c77aff9 100644
>--- a/net/core/user_dma.c
>+++ b/net/core/user_dma.c
>@@ -75,7 +75,7 @@ int dma_skb_copy_datagram_iovec(struct 
>dma_chan *chan,
> 
> 		end = start + skb_shinfo(skb)->frags[i].size;
> 		copy = end - offset;
>-		if ((copy = end - offset) > 0) {
>+		if (copy > 0) {
> 			skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
> 			struct page *page = frag->page;
> 

Acked-by: Shannon Nelson <shannon.nelson@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/