linux-kernel - Re: [PATCH 3/5] pagemap: Make pagemap_read enforce reading in multiples of 8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Jun 2008 12:14:43 -0400
From:	"Thomas Tuttle" <ttuttle@...gle.com>
To:	"Matt Mackall" <mpm@...enic.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] pagemap: Make pagemap_read enforce reading in multiples of 8

On Thu, Jun 5, 2008 at 12:09 PM, Matt Mackall <mpm@...enic.com> wrote:
> Yes, I got that, I'm just mathematically impaired this morning. Read
> that as "when someone tries to do a *20* byte read, do a 16-byte read.."
> In other words, round down to the nearest multiple of 8.

Oh.  I would seriously question doing that, because it would allow
reads that are improperly split up to fail silently.  What happens if
someone tries to read 40 bytes, and (for some reason) it gets split
into two 20-byte reads?  Instead of "12345" they'll get "12.34."
(where . is 4 zero or garbage bytes).  I'd rather they get an error.

--ttuttle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/