linux-kernel - Re: [git pull -tip] headers_check fixes for other architectures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Feb 2009 12:11:10 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Jaswinder Singh Rajput <jaswinder@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Sam Ravnborg <sam@...nborg.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	hskinnemoen@...el.com, cooloney@...nel.org, tony.luck@...el.com,
	ralf@...ux-mips.org, dhowells@...hat.com, matthew@....cx,
	chris@...kel.net, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [git pull -tip] headers_check fixes for other architectures

On Sun, Feb 1, 2009 at 11:49, Ingo Molnar wrote:
> These are the remaining ones on x86:
>
>     17 /dev/shm/tip/usr/include/linux/reiserfs_fs.h
>     12 /dev/shm/tip/usr/include/linux/soundcard.h
>      6 /dev/shm/tip/usr/include/asm/setup.h
>      3 /dev/shm/tip/usr/include/linux/nubus.h
>      2 /dev/shm/tip/usr/include/linux/in6.h
>      1 /dev/shm/tip/usr/include/mtd/jffs2-user.h
>      1 /dev/shm/tip/usr/include/linux/socket.h
>      1 /dev/shm/tip/usr/include/linux/coda_psdev.h
>      1 /dev/shm/tip/usr/include/asm/prctl.h
>
> They are all of the "extern's make no sense in userspace" type. What was the
> verdict, are they worth touching, or should we turn off this warning in
> 'make headers_check'?

the warning wouldnt have been added if it didnt make sense ... like it
says, prototypes for kernel functions make no sense in userspace
headers

as for how it gets solved, we can either patch it manually or
automatically delete the prototypes ... but since prototypes are a big
difficult to match properly with regexes, the former will probably be
saner right now.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/