[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 2 Feb 2009 19:08:11 +0100
From: Ingo Molnar <mingo@...e.hu>
To: Mike Frysinger <vapier.adi@...il.com>
Cc: Jaswinder Singh Rajput <jaswinder@...nel.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Sam Ravnborg <sam@...nborg.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Russell King - ARM Linux <linux@....linux.org.uk>,
hskinnemoen@...el.com, cooloney@...nel.org, tony.luck@...el.com,
ralf@...ux-mips.org, dhowells@...hat.com, matthew@....cx,
chris@...kel.net, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [git pull -tip] headers_check fixes for other architectures
* Mike Frysinger <vapier.adi@...il.com> wrote:
> On Sun, Feb 1, 2009 at 11:49, Ingo Molnar wrote:
> > These are the remaining ones on x86:
> >
> > 17 /dev/shm/tip/usr/include/linux/reiserfs_fs.h
> > 12 /dev/shm/tip/usr/include/linux/soundcard.h
> > 6 /dev/shm/tip/usr/include/asm/setup.h
> > 3 /dev/shm/tip/usr/include/linux/nubus.h
> > 2 /dev/shm/tip/usr/include/linux/in6.h
> > 1 /dev/shm/tip/usr/include/mtd/jffs2-user.h
> > 1 /dev/shm/tip/usr/include/linux/socket.h
> > 1 /dev/shm/tip/usr/include/linux/coda_psdev.h
> > 1 /dev/shm/tip/usr/include/asm/prctl.h
> >
> > They are all of the "extern's make no sense in userspace" type. What was
> > the verdict, are they worth touching, or should we turn off this warning
> > in 'make headers_check'?
>
> the warning wouldnt have been added if it didnt make sense ... like it
> says, prototypes for kernel functions make no sense in userspace headers
the existence of a warning does not justify it. For example the CONFIG_*
warnings were deemed largely bogus and were removed.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists