linux-kernel - Re: [PATCH] rtc-ds1305: Use disable_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 16 Apr 2009 09:31:33 -0700
From:	David Brownell <david-b@...bell.net>
To:	Ben Nizette <bn@...sdigital.com>
Cc:	p_gortmaker@...oo.com,
	"linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtc-ds1305: Use disable_irq_nosync() from within irq handlers.

On Wednesday 15 April 2009, Ben Nizette wrote:
> 
> disable_irq() should wait for all running handlers to complete
> before returning.  As such, if it's used to disable an interrupt
> from that interrupt's handler it will deadlock.  This replaces
> the dangerous instances with the _nosync() variant which doesn't
> have this problem.
> 
> Signed-off-by: Ben Nizette <bn@...sdigital.com>

Acked-by: David Brownell <dbrownell@...rs.sourceforge.net>

Also ... it would be nice to convert this driver to the
new request_threaded_irq() infrastructure.  The board I
had with this chip has a busted ttyS0 *input* line, so it's
not much use for development any more; or I'd update it
myself, it's a simple change.  Someone with that hardware
should think about spending the few minutes needed to make
and test that patch.


> ---
> diff --git a/drivers/rtc/rtc-ds1305.c b/drivers/rtc/rtc-ds1305.c
> index fc372df..5c4f789 100644
> --- a/drivers/rtc/rtc-ds1305.c
> +++ b/drivers/rtc/rtc-ds1305.c
> @@ -514,7 +514,7 @@ static irqreturn_t ds1305_irq(int irq, void *p)
>  {
>  	struct ds1305		*ds1305 = p;
>  
> -	disable_irq(irq);
> +	disable_irq_nosync(irq);
>  	schedule_work(&ds1305->work);
>  	return IRQ_HANDLED;
>  }
> -- 
> 1.6.0.2
> 
> 
> 
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/