[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 05 May 2009 20:43:45 +0300
From: Avi Kivity <avi@...hat.com>
To: Gregory Haskins <ghaskins@...ell.com>
CC: kvm@...r.kernel.org, viro@...IV.linux.org.uk,
linux-kernel@...r.kernel.org, davidel@...ilserver.org
Subject: Re: [KVM PATCH v4 2/2] kvm: add support for irqfd via eventfd-notification
interface
Gregory Haskins wrote:
>>>
>>> +struct kvm_irqfd {
>>> + __u32 gsi;
>>> + __u32 flags;
>>> +};
>>> +
>>>
>>>
>> Please add some reserved space here.
>>
>
> Ack. Any rule of thumb here? How about a "__u8 pad[16]" ?
>
I'd round it up so the whole thing is 32 bytes (not that it matters).
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists