linux-kernel - Re: [PATCH] More i8042-reset quirks for MSI Wind-clone netbooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Jun 2009 09:01:40 +0800
From:	"Li, Yan I" <yan.i.li@...el.com>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"greg@...ah.com" <greg@...ah.com>, yanli@...radead.org
Subject: Re: [PATCH] More i8042-reset quirks for MSI Wind-clone netbooks

On Wed, Jun 17, 2009 at 01:17:32AM +0800, Matthew Garrett wrote:
> So the touchpad on these machines doesn't work with generic Windows? I'm 
> interested in the specifics, not general issues with i8042 
> implementations. We've repeatedly seen that these quirk tables end up 
> inadequately comprehensive and in several cases have masked the actual 
> problem.

Now we have more than 99% machines work well with current i8042 code
path, and less than 1% of machines (those MSI Wind & clones) that
don't work unless being added to this list.

If we do multiple-resetting unconditionally (for all machines), we are
effectively:
1. fixing things that works well
2. make >99% machines (the good citizens) untested

This seems a change too aggressive for me. Do we have a good reason
for taking this risk? 

Of course if we found the "actual problem" we'd conjure up a better
fix. But before that, I'd prefer the conservative way.

-- 
Best regards,
Li, Yan

Moblin Team, Opensource Technology Center, SSG, Intel
Office tel.: +86-10-82171695 (inet: 8-758-1695)
OpenPGP key: 5C6C31EF
IRC: yanli on network irc.freenode.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/