linux-kernel - Re: [dm-devel] REQUEST for new 'topology' metrics to be moved out of the 'queue' sysfs directory.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Jun 2009 15:49:54 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	NeilBrown <neilb@...e.de>
Cc:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Mike Snitzer <snitzer@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Alasdair G Kergon <agk@...hat.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-raid@...r.kernel.org, linux-ide@...r.kernel.org,
	linux-fsdevel@...r.kernel.org,
	device-mapper development <dm-devel@...hat.com>
Subject: Re: [dm-devel] REQUEST for new 'topology' metrics to be moved out
	of the 'queue' sysfs directory.

On Fri, Jun 26 2009, NeilBrown wrote:
> On Fri, June 26, 2009 11:16 pm, NeilBrown wrote:
> > On Fri, June 26, 2009 10:50 pm, Jens Axboe wrote:
> >> On Fri, Jun 26 2009, Neil Brown wrote:
> >
> >>> But for now, please please please can we revert the change which made
> >>> 'queue' appear in md and dm devices, (and loop and ...) and put these
> >>> generic values somewhere ... generic?
> >>
> >> No we cannot, not without a time machine. 2.6.30 is released, so it's
> >> too late to revert things like that, even if we wanted.
> >
> > Drat... for some reason I was thinking that it only came in in 2.6.31-rc.
> > However it is only documented in ABI/testing, not ABI/stable ... if there
> > is any value in that distinction, then it should be possible to move it??
> >
> 
> No, wait.  I was right.  The addition of 'queue' to md/dm devices
> happened post-2.6.30.   So are the additions of physical_block_size etc.
> So there is still time to put these in a properly generic place.

Yes you are right, the commit date had me fooled.

> Do you have a good reason for them going in /queue?

Do you have a good reason for moving them? Im my opinion that makes the
separation between ->make_request_fn and ->request_fn devices bigger.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/