linux-kernel - Re: [PATCH 1/2] kmemleak: Inform kmemleak about kernel stack allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 04 Sep 2009 15:45:49 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] kmemleak: Inform kmemleak about kernel stack
	allocation

On Fri, 2009-09-04 at 08:57 +0200, Ingo Molnar wrote:
> * Catalin Marinas <catalin.marinas@....com> wrote:
> > I tried to move to an inline function and linux/gfp.h is needed for
> > __get_free_pages() and GFP_* macros. This leads to some complicated
> > circular dependencies like below:
> > 
> >   CC      arch/x86/kernel/asm-offsets.s
> > In file included from /work/Linux/2.6/linux-2.6-arm/include/linux/mmzone.h:9,
> >                  from /work/Linux/2.6/linux-2.6-arm/include/linux/gfp.h:4,
> >                  from /work/Linux/2.6/linux-2.6-arm/arch/x86/include/asm/thread_info.h:22,
> >                  from /work/Linux/2.6/linux-2.6-arm/include/linux/thread_info.h:56,
> >                  from /work/Linux/2.6/linux-2.6-arm/include/linux/preempt.h:9,
> >                  from /work/Linux/2.6/linux-2.6-arm/include/linux/spinlock.h:50,
> >                  from /work/Linux/2.6/linux-2.6-arm/include/linux/seqlock.h:29,
> >                  from /work/Linux/2.6/linux-2.6-arm/include/linux/time.h:8,
> >                  from /work/Linux/2.6/linux-2.6-arm/include/linux/stat.h:60,
> >                  from /work/Linux/2.6/linux-2.6-arm/include/linux/module.h:10,
> >                  from /work/Linux/2.6/linux-2.6-arm/include/linux/crypto.h:21,
> >                  from /work/Linux/2.6/linux-2.6-arm/arch/x86/kernel/asm-offsets_32.c:7,
> >                  from /work/Linux/2.6/linux-2.6-arm/arch/x86/kernel/asm-offsets.c:2:
> > include/linux/wait.h|51| error: expected specifier-qualifier-list before ???spinlock_t???
> > 
> > The linux/mmzone.h file normally includes linux/spinlock.h but the 
> > reverse is also true when the latter includes the former via 
> > thread_info.h and gfp.h. Because of the (correct) guards in the 
> > header files, the spinlock_t definition is no longer available in 
> > mmzone.h.
> 
> mmzone.h probably should not include spinlock.h (which is heavy) - 
> it should include spinlock_types.h (which is lighter). It only needs 
> the type definitions and none of the API definitions.

It fixes this particular case but I get plenty of other similar error in
timex.h, jiffies.h, ktime.h, rcutree.h, kmem.h etc.

I'll drop this patch for now and look for alternatives.

-- 
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/