lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 6 Nov 2009 14:48:12 +0100
From:	Sebastian Dalfuß <sd@...f.de>
To:	greg@...ah.com
Cc:	linux-kernel@...r.kernel.org
Subject: [Patch 3/3 v2] staging: rt2860: reduce superfluous exclamation
 marks

From: Sebastian Dalfuß <sd@...f.de>

This patch is based on next-20091106.
This patch reduces the number of exclamation marks in DBGPRINT() and
printk() strings (also comments) to a slightly less insane number.

Signed-off-by: Sebastian Dalfuß <sd@...f.de>
---
diff -ru b/drivers/staging/rt2860/common/cmm_data.c c/drivers/staging/rt2860/common/cmm_data.c
--- b/drivers/staging/rt2860/common/cmm_data.c	2009-11-06 08:03:10.000000000 +0100
+++ c/drivers/staging/rt2860/common/cmm_data.c	2009-11-06 12:04:42.201639959 +0100
@@ -1729,7 +1729,7 @@
 				  pAd->MacTab.Size));
 		} else {
 			DBGPRINT(RT_DEBUG_OFF,
-				 ("\n%s: Impossible Wcid = %d !!!!!\n",
+				 ("\n%s: Impossible Wcid = %d !!!\n",
 				  __func__, wcid));
 		}
 	}
diff -ru b/drivers/staging/rt2860/common/mlme.c c/drivers/staging/rt2860/common/mlme.c
--- b/drivers/staging/rt2860/common/mlme.c	2009-11-06 08:03:10.000000000 +0100
+++ c/drivers/staging/rt2860/common/mlme.c	2009-11-06 12:04:42.431640138 +0100
@@ -4600,7 +4600,7 @@
  * input params:
  *		Buffer - pointer to a pre-allocated memory segment
  *		args - a list of <int arg_size, arg> pairs.
- *		NOTE NOTE NOTE!!!! the last argument must be NULL, otherwise this
+ *		NOTE NOTE NOTE!!! the last argument must be NULL, otherwise this
  *						   function will FAIL!!!
  * return:
  *		Size of the buffer
diff -ru b/drivers/staging/rt2860/rtmp_def.h c/drivers/staging/rt2860/rtmp_def.h
--- b/drivers/staging/rt2860/rtmp_def.h	2009-11-06 08:03:10.000000000 +0100
+++ c/drivers/staging/rt2860/rtmp_def.h	2009-11-06 12:04:42.614973444 +0100
@@ -409,7 +409,7 @@
 #define MAX_LEN_OF_MAC_TABLE            MAX_NUMBER_OF_MAC	/* if MAX_MBSSID_NUM is 8, this value can't be larger than 211 */
 
 #if MAX_LEN_OF_MAC_TABLE>MAX_AVAILABLE_CLIENT_WCID
-#error MAX_LEN_OF_MAC_TABLE can not be larger than MAX_AVAILABLE_CLIENT_WCID!!!!
+#error MAX_LEN_OF_MAC_TABLE can not be larger than MAX_AVAILABLE_CLIENT_WCID!!!
 #endif
 
 #define MAX_NUM_OF_WDS_LINK_PERBSSID	            3
diff -ru b/drivers/staging/rt2860/sta/assoc.c c/drivers/staging/rt2860/sta/assoc.c
--- b/drivers/staging/rt2860/sta/assoc.c	2009-11-06 08:03:10.000000000 +0100
+++ c/drivers/staging/rt2860/sta/assoc.c	2009-11-06 12:04:42.714973141 +0100
@@ -563,7 +563,7 @@
 		pAd->Mlme.AssocMachine.CurrState = ASSOC_WAIT_RSP;
 	} else {
 		DBGPRINT(RT_DEBUG_TRACE,
-			 ("ASSOC - MlmeAssocReqAction() sanity check failed. BUG!!!!!! \n"));
+			 ("ASSOC - MlmeAssocReqAction() sanity check failed. BUG!!! \n"));
 		pAd->Mlme.AssocMachine.CurrState = ASSOC_IDLE;
 		Status = MLME_INVALID_FORMAT;
 		MlmeEnqueue(pAd, MLME_CNTL_STATE_MACHINE, MT2_ASSOC_CONF, 2,
@@ -746,7 +746,7 @@
 		pAd->Mlme.AssocMachine.CurrState = REASSOC_WAIT_RSP;
 	} else {
 		DBGPRINT(RT_DEBUG_TRACE,
-			 ("ASSOC - MlmeReassocReqAction() sanity check failed. BUG!!!! \n"));
+			 ("ASSOC - MlmeReassocReqAction() sanity check failed. BUG!!! \n"));
 		pAd->Mlme.AssocMachine.CurrState = ASSOC_IDLE;
 		Status = MLME_INVALID_FORMAT;
 		MlmeEnqueue(pAd, MLME_CNTL_STATE_MACHINE, MT2_REASSOC_CONF, 2,
diff -ru b/drivers/staging/rt2860/sta/connect.c c/drivers/staging/rt2860/sta/connect.c
--- b/drivers/staging/rt2860/sta/connect.c	2009-11-06 08:03:10.000000000 +0100
+++ c/drivers/staging/rt2860/sta/connect.c	2009-11-06 12:04:42.751640132 +0100
@@ -911,7 +911,7 @@
 				  pAd->CommonCfg.Bssid[5]));
 		} else {
 			DBGPRINT(RT_DEBUG_TRACE,
-				 ("CNTL - Start IBSS fail. BUG!!!!!\n"));
+				 ("CNTL - Start IBSS fail. BUG!!!\n"));
 			pAd->Mlme.CntlMachine.CurrState = CNTL_IDLE;
 		}
 	}
diff -ru b/drivers/staging/rt2860/sta/rtmp_data.c c/drivers/staging/rt2860/sta/rtmp_data.c
--- b/drivers/staging/rt2860/sta/rtmp_data.c	2009-11-06 08:03:10.000000000 +0100
+++ c/drivers/staging/rt2860/sta/rtmp_data.c	2009-11-06 12:04:42.808307173 +0100
@@ -1680,7 +1680,7 @@
 
 		pMacEntry = pTxBlk->pMacEntry;
 		if (pMacEntry->isCached) {
-			/* NOTE: Please make sure the size of pMacEntry->CachedBuf[] is smaller than pTxBlk->HeaderBuf[]!!!! */
+			/* NOTE: Please make sure the size of pMacEntry->CachedBuf[] is smaller than pTxBlk->HeaderBuf[]!!! */
 			NdisMoveMemory((u8 *)& pTxBlk->
 				       HeaderBuf[TXINFO_SIZE],
 				       (u8 *)& pMacEntry->CachedBuf[0],
diff -ru b/drivers/staging/rt2860/usb_main_dev.c c/drivers/staging/rt2860/usb_main_dev.c
--- b/drivers/staging/rt2860/usb_main_dev.c	2009-11-06 08:03:10.000000000 +0100
+++ c/drivers/staging/rt2860/usb_main_dev.c	2009-11-06 12:04:42.851640100 +0100
@@ -584,7 +584,7 @@
 	RTMP_IO_READ32(pAd, TXRXQ_PCNT, &MACValue);
 	if ((MACValue & 0xff) != 0) {
 		DBGPRINT(RT_DEBUG_TRACE,
-			 ("TX QUEUE 0 Not EMPTY(Value=0x%0x). !!!!!!!!!!!!!!!\n",
+			 ("TX QUEUE 0 Not EMPTY(Value=0x%0x). !!!\n",
 			  MACValue));
 		RTMP_IO_WRITE32(pAd, PBF_CFG, 0xf40012);
 		while ((MACValue & 0xff) != 0 && (idx++ < 10)) {
@@ -707,7 +707,7 @@
 					}
 				} else {
 					DBGPRINT(RT_DEBUG_ERROR,
-						 ("Unkonw bulkOut URB maybe hanged!!!!!!!!!!!!\n"));
+						 ("Unknown bulkOut URB maybe hanged!!!\n"));
 				}
 			} else {
 				RTMP_IRQ_UNLOCK(&pAd->BulkOutLock[idx],


Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ