linux-kernel - Re: [Patch 3/3 v2] staging: rt2860: reduce superfluous exclamation marks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Nov 2009 14:59:31 -0800
From:	Greg KH <greg@...ah.com>
To:	Sebastian Dalfuß <sd@...f.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [Patch 3/3 v2] staging: rt2860: reduce superfluous exclamation
 marks

On Fri, Nov 06, 2009 at 02:48:12PM +0100, Sebastian Dalfuß wrote:
> From: Sebastian Dalfuß <sd@...f.de>
> 
> This patch is based on next-20091106.
> This patch reduces the number of exclamation marks in DBGPRINT() and
> printk() strings (also comments) to a slightly less insane number.
> 
> Signed-off-by: Sebastian Dalfuß <sd@...f.de>
> ---
> diff -ru b/drivers/staging/rt2860/common/cmm_data.c c/drivers/staging/rt2860/common/cmm_data.c
> --- b/drivers/staging/rt2860/common/cmm_data.c	2009-11-06 08:03:10.000000000 +0100
> +++ c/drivers/staging/rt2860/common/cmm_data.c	2009-11-06 12:04:42.201639959 +0100
> @@ -1729,7 +1729,7 @@
>  				  pAd->MacTab.Size));
>  		} else {
>  			DBGPRINT(RT_DEBUG_OFF,
> -				 ("\n%s: Impossible Wcid = %d !!!!!\n",
> +				 ("\n%s: Impossible Wcid = %d !!!\n",

Heh, this is funny.  How did you determine that 3 '!' is acceptable when
4 or 5 '!' are not?

As this is a pretty pointless patch, I'm not going to apply it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/