linux-kernel - Re: [PATCH v7] USB device driver of Topcliff PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Nov 2010 13:29:58 +0100
From:	Michał Nazarewicz <m.nazarewicz@...sung.com>
To:	Andy Isaacson <adi@...apodia.org>,
	Toshiharu Okada <toshiharu-linux@....okisemi.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-usb <linux-usb@...r.kernel.org>,
	"Wang, Qi" <qi.wang@...el.com>,
	"Wang, Yong Y" <yong.y.wang@...el.com>,
	Andrew <andrew.chih.howe.khor@...el.com>,
	Intel OTC <joel.clark@...el.com>,
	"Foster, Margie" <margie.foster@...el.com>,
	"Ewe, Kok Howg" <kok.howg.ewe@...el.com>
Subject: Re: [PATCH v7] USB device driver of Topcliff PCH

On Tue, 09 Nov 2010 05:57:05 +0100, Toshiharu Okada <toshiharu-linux@....okisemi.com> wrote:
> I will modify to "if-else-if-else" as follows.

> if (!list_empty(&ep->queue)) {
>     dev_dbg(&dev->pdev->dev, "%s: list not empty", __func__);
>     ret = -EAGAIN;
> } else {
>     if (halt) { /* halt or clear halt */
>         if (ep->num == PCH_UDC_EP0)
>             ep->dev->stall = 1;
>         pch_udc_ep_set_stall(ep);
>         pch_udc_enable_ep_interrupts(ep->dev, PCH_UDC_EPINT(ep->in,
> ep->num));
>         ret = 0;
>     } else {
>         pch_udc_ep_clear_stall(ep);
>         ret = 0;
>     }
> }

In that case, make it:

if (list_empty(&ep->queue)) {
	if (halt) { /* halt or clear halt */
		if (ep->num == PCH_UDC_EP0)
			ep->dev->stall = 1;
		pch_udc_ep_set_stall(ep);
		pch_udc_enable_ep_interrupts(ep->dev, PCH_UDC_EPINT(ep->in, ep->num));
	} else {
		pch_udc_ep_clear_stall(ep);
	}
	ret = 0;
} else {
	dev_dbg(&dev->pdev->dev, "%s: list not empty", __func__);
	ret = -EAGAIN;
}

Ie. no need to put "ret = 0;" twice in the code.

-- 
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  Michał "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/